Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increment type hints and add mypy #166

Open
avara1986 opened this issue Sep 29, 2020 · 3 comments · Fixed by #167 or #177
Open

Increment type hints and add mypy #166

avara1986 opened this issue Sep 29, 2020 · 3 comments · Fixed by #167 or #177
Assignees
@ooigavin @AmandaKhol @mbcaldeiro
Labels
feature New feature in progres Hacktoberfest help wanted Extra attention is needed

Comments

@avara1986
Copy link
Member

Add more Python type hints and add mypy valitations. This validation could be a step in GH actions or tox

You can learn more about type hints in this link

Mypy has a command line checker:

mypy pyms

Ideally, mypy must return 0 errors, but could be a hard work because pyms create dynamic attributes.
@avara1986 avara1986 added help wanted Extra attention is needed Hacktoberfest feature New feature in progres labels Sep 29, 2020
@ooigavin
Copy link
Contributor

Hi @avara1986 would like to pick this one up!

@avara1986
Copy link
Member Author

Thank you @ooigavin ! ^^ Don't forget to register in https://hacktoberfest.digitalocean.com/ 👍

@avara1986 avara1986 linked a pull request Sep 30, 2020 that will close this issue
Updated type hinting #167
Merged
@avara1986 avara1986 reopened this Sep 30, 2020
@avara1986 avara1986 linked a pull request Oct 8, 2020 that will close this issue
Add mypy check to github actions #177
Merged
@avara1986 avara1986 reopened this Oct 8, 2020
@mbcaldeiro
Copy link

Quisiera recoger esta issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ooigavin ooigavin

@AmandaKhol AmandaKhol

@mbcaldeiro mbcaldeiro

Labels
feature New feature in progres Hacktoberfest help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updated type hinting python-microservices/pyms
Add mypy check to github actions
4 participants
@avara1986 @ooigavin @AmandaKhol @mbcaldeiro