move content metadata to the encrypted payload #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pythcoiner
commented
Sep 12, 2025
| } | ||
|
|
||
| /// Encode content metadata, 3 variants: | ||
| /// - <LENGTH == 0> => None |
There was a problem hiding this comment.
@Sjors here we can add this variant to support multiples contents:
/// - <LENGTH == 0xFF><CONTENTS_COUNT><CONTENT_1>...<CONTENT_N>
where inners <CONTENT_X> cannot have a LENGTH == 0xFF to avoid recursion, wdyt?
pythcoiner
force-pushed
the
content_private
branch
from
2d85be4 to
63e7811
Compare
pythcoiner
force-pushed
the
content_private
branch
from
63e7811 to
7eab4c2
Compare
pythcoiner
force-pushed
the
content_private
branch
from
ac59283 to
9702070
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR move content metada in the encrypted payload and allow to define the content in a different BIP
partially adresses this [comment(https://github.com/bitcoin/bips/pull/1951#discussion_r2321215113)