Repository navigation
fix(investigation): declare ranges for numeric CLI options (#1562) - #1673
Open
Mohit-Gaur75 wants to merge 1 commit into
Open
Mohit-Gaur75 wants to merge 1 commit into
Mohit-Gaur75 wants to merge 1 commit into
Conversation
markramm
reviewed
Nov 17, 2026
markramm
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for taking #1562 and for removing exactly the rows you bounded.
Blocking
None found. The 13 options you bounded match the 13 NOT_YET rows you removed (timeline 2, entities 2, sources 1, claims 2, qa 1, search 1, ownership 1, money-flow 1, export 1, dedup 1), and NOT_YET_PINNED_SIZE goes 29 to 16, which is 29 minus 13, so the ratchet still balances by my reading.
Non-blocking
cli.py(timeline,entities,claims,export):--min-importancenow accepts 0 to 10, but the help text still says "(1-10)". 0 is the default and means "no filter", so the range is right; please change the help to "(0-10, 0 = no filter)".changelog.d/1562-investigation-numeric-ranges.fixed.md: it lists the new ranges but not the old answer. Add one clause such as "--limit 0and negative values were passed through to the query" so a reader knows what changed.tests/test_cli_numeric_options_declare_a_range.py: open PR #1614 deletesNOT_YET_PINNED_SIZEand changes this file, so yourNOT_YET_PINNED_SIZE = 16edit will conflict textually with it (the row removals are a few lines away and may merge). Whichever lands second drops the pin line; we will sort that out at merge, nothing for you to do now.tests/test_cli_option_ranges.py: it checks exit code 2 and the option name only. Add one valid boundary case (--limit 1,--min-importance 10) so a range tightened too far is also caught.
Recommendation: merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1562. Follows #1541.
Description
Declares the valid numeric ranges for all 13 numeric options across pyrite investigation CLI commands:
Removes all 13 rows from NOT_YET in ests/test_cli_numeric_options_declare_a_range.py and decrements NOT_YET_PINNED_SIZE from 29 to 16.
Adds unit tests in extensions/journalism-investigation/tests/test_cli_option_ranges.py asserting that out-of-range inputs exit with code 2 and print usage error messages naming the option.
Changelog: fixed