PyPI package event notification feature #5714

vishleshp · 2019-04-18T04:22:09Z

What's the problem this feature will solve?
It seems deleting a pypi package is possible - How to remove a package from Pypi

This can cause problems if multiple team members have access to PyPI account holding the PyPI package and permissions. A person can accidentally delete a package if a person don't know dependent packages using the specific versions of a particular package.

It would be great if pypi starts supporting notifications feature where PyPI can send a notification if someone performs delete operation.

Also, in addition, it would be great to have notification when someone performs a upload of new package in PyPI repo, everyone receives notification.

Describe the solution you'd like

Basic ask:
It would be great if PyPI starts supporting notifications feature where PyPI can send a notification if someone performs delete operation.
Good to have:
It would be great to have notification when someone performs a upload of new package in PyPI repo, everyone receives notification.

Additional context
https://stackoverflow.com/questions/55710802/how-to-protect-pypi-package-from-being-deleted

brainwane · 2019-05-16T15:51:56Z

My gut tells me we should implement this with or after #5863, and that it might in fact be blocked on #5863.

brainwane · 2019-05-16T18:21:09Z

Yup: to do this the right way, we should wait till we have #5863 implemented, so we can draw on the event logging and use it to trigger this notification.

brainwane · 2019-08-15T21:36:26Z

Now unblocked! See #5863 for related issues and requests for notifications of specific kinds of events, and #6339 for events currently being logged.

calvin · 2019-09-13T10:13:55Z

What would be the notification medium? Email?

vishleshpatel · 2019-09-13T14:12:52Z

@calvin email shall be sufficient. Even better if SMS can be added too.

calvin · 2019-09-14T13:01:46Z

Scope:

Send a email notification to all collaborators when new version of the package is uploaded.
Send a email notification to all collaborators when a version is deleted.
Send a email notification to all collaborators when a file from a version is deleted.
Send a email notification to all collaborators when the project is deleted.

MVrachev · 2019-12-02T14:45:55Z

@calvin are you working on this?

If not, I want to work on that issue.

MVrachev · 2019-12-09T15:28:45Z

I will work on this.
First I plan to implement email notifications to all contributors when

project was deleted
a version of a project was deleted

Then probably I will work on the rest of the features.

This commit is a first part of implementing issue pypi#5714. Signed-off-by: Martin Vrachev <[email protected]>

This commit is the first part of implementing issue pypi#5714. Signed-off-by: Martin Vrachev <[email protected]>

MVrachev · 2019-12-19T09:17:37Z

How can I test this feature locally?

I didn't succeed with trying:

I created a new build with my changes.
Then I used make serve and make initdb
I logged in with the ewdurbin profile.
In Account options, I added my email address.
From the logs, it seems that the email was successfully sent.
Then I looked at my profile and I didn't saw any email from Warehouse...
Checked multiple times with 2 different email addresses.

ewdurbin · 2019-12-20T18:54:16Z

@MVrachev local development environment for warehouse does not deliver emails to the internet. instead, the emails are accepted by the development SMTP service stand-in and will appear in the docker logs.

That's not the most friendly, we should probably look into replacing this stand-in with something like MailHog.

Until now, where there are multiple contributors on a single the project, if one of them deletes a release or the whole project the other contributors don't get any notification, which is problematic. Connected with issue pypi#5714. Signed-off-by: Martin Vrachev <[email protected]>

MVrachev · 2020-02-27T10:12:17Z

The base work for

Send a email notification to all collaborators when a version is deleted.
Send a email notification to all collaborators when a version is deleted.

is completed by me in pr #7071

I plan to continue my work with:

Send a email notification to all collaborators when a file from a version is deleted.

After reading issue #997 I realized that
Send a email notification to all collaborators when new version of the package is uploaded is not so simple to be implemented if you want to do it the right way with option to opt out from those emails.

That's why I think Send a email notification to all collaborators when new version of the package is uploaded is shouldn't be considered as part of this issue.

MVrachev · 2020-02-27T13:24:02Z

@calvin when you mentioned that it will be good to Send a email notification to all collaborators when a file from a version is deleted. what did you mean?

I find in the warehouse repository only delete_project_release_file function in the warehouse\manage\views.py file.
Do you mean that?

Until now, where there are multiple contributors on a single the project, if one of them deletes a release or the whole project the other contributors don't get any notification, which is problematic. Connected with issue pypi#5714. Signed-off-by: Martin Vrachev <[email protected]>

* Add email notication on package/release removal Until now, where there are multiple contributors on a single the project, if one of them deletes a release or the whole project the other contributors don't get any notification, which is problematic. Connected with issue #5714. Signed-off-by: Martin Vrachev <[email protected]> * Use lower case for submitter role Signed-off-by: Martin Vrachev <[email protected]> * Update messages.pot with remove emails Signed-off-by: Martin Vrachev <[email protected]>

Until now, when there are multiple contributors on a single the project, if one of them deletes a file from certain release the other contributors don't get any notification, which is problematic. Connected with issue pypi#5714 Signed-off-by: Martin Vrachev <[email protected]>

Until now, when there are multiple contributors on a single the project, if one of them deletes a file from certain release the other contributors don't get any notification, which is problematic. Connected with issue #5714 Signed-off-by: Martin Vrachev <[email protected]>

berinhard · 2021-05-04T14:46:14Z

Should this issue still be open? @vishleshp says at the issue description:

Basic ask:
It would be great if PyPI starts supporting notifications feature where PyPI can send a notification if someone performs delete operation.
Good to have:
It would be great to have notification when someone performs a upload of new package in PyPI repo, everyone receives notification.

I think #7071 and #7498 (thanks @MVrachev) already covers the basic part and #997 address what's left in a more detailed way. But I'm not sure if this issue also stands for a more generic and extensible notification system. Is that the case?

di · 2021-12-01T00:58:10Z

Yep, closing this.

di added the feature request label Apr 30, 2019

di changed the title ~~Pypi package event notification feature~~ PyPI package event notification feature Apr 30, 2019

di added the good first issue This issue is ideal for first-time contributors! label May 4, 2019

brainwane added the blocked Issues we can't or shouldn't get to yet label May 16, 2019

brainwane added help needed We'd love volunteers to advise on or help fix/implement this. and removed blocked Issues we can't or shouldn't get to yet labels Aug 15, 2019

This was referenced Aug 15, 2019

Security Notification Systems for Python Packages #798

Open

Email all owners when a new version of a package is uploaded #997

Closed

MVrachev added a commit to MVrachev/warehouse that referenced this issue Dec 9, 2019

Add templates of removal of a pkg/pkg release

6fa91f0

This commit is a first part of implementing issue pypi#5714. Signed-off-by: Martin Vrachev <[email protected]>

MVrachev added a commit to MVrachev/warehouse that referenced this issue Dec 9, 2019

Add templates of removal of a pkg/pkg release

c0c3e42

This commit is a first part of implementing issue pypi#5714. Signed-off-by: Martin Vrachev <[email protected]>

MVrachev added a commit to MVrachev/warehouse that referenced this issue Dec 9, 2019

Add templates of removal of a pkg/pkg release

18c8e53

This commit is the first part of implementing issue pypi#5714. Signed-off-by: Martin Vrachev <[email protected]>

MVrachev mentioned this issue Dec 9, 2019

Add email notification on project/release removal #7071

Merged

MVrachev added a commit to MVrachev/warehouse that referenced this issue Dec 9, 2019

Add templates of removal of a pkg/pkg release

217a29b

This commit is the first part of implementing issue pypi#5714. Signed-off-by: Martin Vrachev <[email protected]>

MVrachev added a commit to MVrachev/warehouse that referenced this issue Dec 9, 2019

Add templates of removal of a pkg/pkg release

9a22e56

This commit is the first part of implementing issue pypi#5714. Signed-off-by: Martin Vrachev <[email protected]>

MVrachev mentioned this issue Mar 5, 2020

Add email templates for removed file from release #7498

Merged

di closed this as completed Dec 1, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PyPI package event notification feature #5714

PyPI package event notification feature #5714

vishleshp commented Apr 18, 2019 •

edited by di

Loading

brainwane commented May 16, 2019

brainwane commented May 16, 2019

brainwane commented Aug 15, 2019

calvin commented Sep 13, 2019

vishleshpatel commented Sep 13, 2019

calvin commented Sep 14, 2019

MVrachev commented Dec 2, 2019

MVrachev commented Dec 9, 2019 •

edited

Loading

MVrachev commented Dec 19, 2019

ewdurbin commented Dec 20, 2019 •

edited

Loading

MVrachev commented Feb 27, 2020

MVrachev commented Feb 27, 2020

berinhard commented May 4, 2021

di commented Dec 1, 2021

PyPI package event notification feature #5714

PyPI package event notification feature #5714

Comments

vishleshp commented Apr 18, 2019 • edited by di Loading

brainwane commented May 16, 2019

brainwane commented May 16, 2019

brainwane commented Aug 15, 2019

calvin commented Sep 13, 2019

vishleshpatel commented Sep 13, 2019

calvin commented Sep 14, 2019

MVrachev commented Dec 2, 2019

MVrachev commented Dec 9, 2019 • edited Loading

MVrachev commented Dec 19, 2019

ewdurbin commented Dec 20, 2019 • edited Loading

MVrachev commented Feb 27, 2020

MVrachev commented Feb 27, 2020

berinhard commented May 4, 2021

di commented Dec 1, 2021

vishleshp commented Apr 18, 2019 •

edited by di

Loading

MVrachev commented Dec 9, 2019 •

edited

Loading

ewdurbin commented Dec 20, 2019 •

edited

Loading