remove _project_docs empty release option

Author: callmecampos

tests/unit/search/test_tasks.py

@@ -47,12 +47,13 @@ def test_project_docs(db_session):
 
     for p in projects:
         for r in releases[p]:
-            f = FileFactory.create(
-                release=r,
-                filename="{}-{}.tar.gz".format(p.name, r.version),
-                python_version="source",
-            )
-            r.files.append(f)
+            r.files = [
+                FileFactory.create(
+                    release=r,
+                    filename="{}-{}.tar.gz".format(p.name, r.version),
+                    python_version="source",
+                )
+            ]
 
     assert list(_project_docs(db_session)) == [
         {
@@ -86,12 +87,13 @@ def test_single_project_doc(db_session):
 
     for p in projects:
         for r in releases[p]:
-            f = FileFactory.create(
-                release=r,
-                filename="{}-{}.tar.gz".format(p.name, r.version),
-                python_version="source",
-            )
-            r.files.append(f)
+            r.files = [
+                FileFactory.create(
+                    release=r,
+                    filename="{}-{}.tar.gz".format(p.name, r.version),
+                    python_version="source",
+                )
+            ]
 
     assert list(_project_docs(db_session, project_name=projects[1].name)) == [
         {

warehouse/accounts/services.py

@@ -15,11 +15,11 @@
 import hashlib
 import hmac
 import logging
-import posixpath
 import secrets
 import urllib.parse
 import uuid
 
+import posixpath
 import requests
 
 from passlib.context import CryptContext

warehouse/search/tasks.py

@@ -37,15 +37,11 @@
 from warehouse.utils.db import windowed_query
 
 
-def _project_docs(db, project_name=None, show_empty_releases=False):
-
-    queries = [Release.yanked.is_(False)]
-    if not show_empty_releases:
-        queries.append(Release.files)
+def _project_docs(db, project_name=None):
 
     releases_list = (
         db.query(Release.id)
-        .filter(*queries)
+        .filter(Release.yanked.is_(False), Release.files)
         .order_by(
             Release.project_id,
             Release.is_prerelease.nullslast(),