Skip to content

Feature request: Add type hints to parser (and library) #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
miketheman opened this issue Jun 14, 2023 · 0 comments · Fixed by #130
Closed

Feature request: Add type hints to parser (and library) #123

miketheman opened this issue Jun 14, 2023 · 0 comments · Fixed by #130

Comments

@miketheman
Copy link
Member

miketheman commented Jun 14, 2023 •
edited
Loading

As the library is used in warehouse, the structure emitted from parse() is unclear to callers. We end up disabling this library from type checking.

I think that function should generally return a UserAgent, is that correct?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add type hints miketheman/linehaul-cloud-function
1 participant
@miketheman