Skip to content

Commit 293886f

Browse files
committed
add new tests for these cases
1 parent 452c5ba commit 293886f

File tree

1 file changed

+19
-18
lines changed

1 file changed

+19
-18
lines changed

Diff for: tests/integration/test_update.py

+19-18
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import pytest
22

3+
from pipenv.project import Project
34
from pipenv.routines.update import get_modified_pipfile_entries
45

56

@@ -18,8 +19,8 @@ def test_update_outdated_with_outdated_package(pipenv_instance_private_pypi, cmd
1819
assert f"Package '{package_name}' out-of-date:" in c.stdout
1920

2021

21-
def test_get_modified_pipfile_entries_new_package(pipenv_instance_private_pypi):
22-
with pipenv_instance_private_pypi() as p:
22+
def test_get_modified_pipfile_entries_new_package(pipenv_instance_pypi):
23+
with pipenv_instance_pypi() as p:
2324
# Add package to Pipfile but don't lock
2425
p.pipenv("install requests==2.31.0")
2526
p.remove_lockfile()
@@ -32,13 +33,13 @@ def test_get_modified_pipfile_entries_new_package(pipenv_instance_private_pypi):
3233
'[packages]\nurllib3 = "==2.0.0"'
3334
)
3435
pipfile.write_text(content)
35-
36-
modified = get_modified_pipfile_entries(p.project, ["packages"])
36+
project = Project()
37+
modified = get_modified_pipfile_entries(project, ["packages"])
3738
assert "urllib3" in modified["default"]
3839

3940

40-
def test_get_modified_pipfile_entries_changed_version(pipenv_instance_private_pypi):
41-
with pipenv_instance_private_pypi() as p:
41+
def test_get_modified_pipfile_entries_changed_version(pipenv_instance_pypi):
42+
with pipenv_instance_pypi() as p:
4243
# Install and lock initial version
4344
p.pipenv("install requests==2.31.0")
4445

@@ -50,13 +51,13 @@ def test_get_modified_pipfile_entries_changed_version(pipenv_instance_private_py
5051
'requests = "==2.32.0"'
5152
)
5253
pipfile.write_text(content)
53-
54-
modified = get_modified_pipfile_entries(p.project, ["packages"])
54+
project = Project()
55+
modified = get_modified_pipfile_entries(project, ["packages"])
5556
assert "requests" in modified["default"]
5657

5758

58-
def test_get_modified_pipfile_entries_vcs_changes(pipenv_instance_private_pypi):
59-
with pipenv_instance_private_pypi() as p:
59+
def test_get_modified_pipfile_entries_vcs_changes(pipenv_instance_pypi):
60+
with pipenv_instance_pypi() as p:
6061
# Install VCS package
6162
p.pipenv("install git+https://github.com/requests/requests.git@main#egg=requests")
6263

@@ -68,13 +69,13 @@ def test_get_modified_pipfile_entries_vcs_changes(pipenv_instance_private_pypi):
6869
'ref = "master"'
6970
)
7071
pipfile.write_text(content)
71-
72-
modified = get_modified_pipfile_entries(p.project, ["packages"])
72+
project = Project()
73+
modified = get_modified_pipfile_entries(project, ["packages"])
7374
assert "requests" in modified["default"]
7475

7576

76-
def test_update_without_lockfile(pipenv_instance_private_pypi):
77-
with pipenv_instance_private_pypi() as p:
77+
def test_update_without_lockfile(pipenv_instance_pypi):
78+
with pipenv_instance_pypi() as p:
7879
# Install without creating lockfile
7980
p.pipenv("install --skip-lock requests==2.31.0")
8081
p.remove_lockfile()
@@ -104,15 +105,15 @@ def test_update_without_lockfile(pipenv_instance_private_pypi):
104105
)
105106
]
106107
)
107-
def test_update_modified_packages(pipenv_instance_private_pypi, pipfile_content, expected_updates):
108-
with pipenv_instance_private_pypi() as p:
108+
def test_update_modified_packages(pipenv_instance_pypi, pipfile_content, expected_updates):
109+
with pipenv_instance_pypi() as p:
109110
# Setup initial state
110111
p.pipenv("install requests==2.31.0")
111112

112113
# Modify Pipfile
113114
pipfile = p.path / "Pipfile"
114115
pipfile.write_text(pipfile_content)
115-
116+
project = Project()
116117
# Verify correct packages identified for update
117-
modified = get_modified_pipfile_entries(p.project, ["packages", "dev-packages"])
118+
modified = get_modified_pipfile_entries(project, ["packages", "dev-packages"])
118119
assert set(modified["default"]).union(set(modified["develop"])) == expected_updates

0 commit comments

Comments
 (0)