Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace boolean parameter with two methods. #323

Open
jaraco opened this issue Dec 26, 2024 · 0 comments
Open

Replace boolean parameter with two methods. #323

jaraco opened this issue Dec 26, 2024 · 0 comments

Comments

@jaraco
Copy link
Member

jaraco commented Dec 26, 2024

This complicated signature, caused by a boolean parameter, should probably be re-written as two methods, get_command_obj and get_cached_command_obj, where the latter just returns self.command_obj.get(command). Of course, that's not a concern for this PR.

Originally posted by @jaraco in #307 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant