From bf4fc386cd18a1898cc8853086d406610e2eca56 Mon Sep 17 00:00:00 2001
From: Ipuch <pierre.puchaud@umontreal.ca>
Date: Thu, 28 Nov 2024 14:05:29 -0500
Subject: [PATCH] refactor: rerun by columns now !

---
 pyorerun/multi_frame_rate_phase_rerun.py | 4 ++--
 pyorerun/multi_phase_rerun.py            | 4 ++--
 pyorerun/phase_rerun.py                  | 4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/pyorerun/multi_frame_rate_phase_rerun.py b/pyorerun/multi_frame_rate_phase_rerun.py
index 1f3ec2b..dcb2dd4 100644
--- a/pyorerun/multi_frame_rate_phase_rerun.py
+++ b/pyorerun/multi_frame_rate_phase_rerun.py
@@ -73,7 +73,7 @@ def cumulative_frames_in_merged_t_span(self) -> list[list[int]]:
         frame_t_span_idx = self.frame_t_span_idx
         return [calculate_cumulative_frames(p, frame_t_span_idx) for p in range(self.nb_phases)]
 
-    def rerun(
+    def rerun_by_frame(
         self, name: str = "animation_phase", init: bool = True, clear_last_node: bool = False, notebook: bool = False
     ) -> None:
         if self.nb_phases == 1:
@@ -107,7 +107,7 @@ def rerun(
                 ]:
                     rr.log(component, rr.Clear(recursive=False))
 
-    def rerun_with_chunks(
+    def rerun(
         self, name: str = "animation_phase", init: bool = True, clear_last_node: bool = False, notebook: bool = False
     ) -> None:
         if self.nb_phases == 1:
diff --git a/pyorerun/multi_phase_rerun.py b/pyorerun/multi_phase_rerun.py
index 3bf2a0c..cc7bfa8 100644
--- a/pyorerun/multi_phase_rerun.py
+++ b/pyorerun/multi_phase_rerun.py
@@ -77,7 +77,7 @@ def windows(self, phase: int = 0) -> list[str]:
     def all_windows(self) -> list[str]:
         return [windows for phase in self.rerun_biorbd_phases for windows in phase.keys()]
 
-    def rerun(self, server_name: str = "multi_phase_animation", notebook=False) -> None:
+    def rerun_by_frame(self, server_name: str = "multi_phase_animation", notebook=False) -> None:
         rr.init(server_name, spawn=True if not notebook else False)
         for i, phase in enumerate(self.rerun_biorbd_phases):
             for j, (window, rr_phase) in enumerate(phase.items()):
@@ -90,7 +90,7 @@ def rerun(self, server_name: str = "multi_phase_animation", notebook=False) -> N
                 more_phases_after_this_one = i < self.nb_phase - 1
                 rr_phase.rerun(init=False, clear_last_node=more_phases_after_this_one)
 
-    def rerun_with_chunks(self, server_name: str = "multi_phase_animation", notebook=False) -> None:
+    def rerun(self, server_name: str = "multi_phase_animation", notebook=False) -> None:
         rr.init(server_name, spawn=True if not notebook else False)
         for i, phase in enumerate(self.rerun_biorbd_phases):
             for j, (window, rr_phase) in enumerate(phase.items()):
diff --git a/pyorerun/phase_rerun.py b/pyorerun/phase_rerun.py
index e88aa80..efda728 100644
--- a/pyorerun/phase_rerun.py
+++ b/pyorerun/phase_rerun.py
@@ -190,7 +190,7 @@ def add_video(self, name, video_array: np.ndarray) -> None:
 
         self.xp_data.add_data(Video(name=f"{self.name}/{name}", video_array=video_array))
 
-    def rerun(
+    def rerun_by_frame(
         self, name: str = "animation_phase", init: bool = True, clear_last_node: bool = False, notebook: bool = False
     ) -> None:
         if init:
@@ -215,7 +215,7 @@ def rerun(
             ]:
                 rr.log(component, rr.Clear(recursive=False))
 
-    def rerun_with_chunks(
+    def rerun(
         self, name: str = "animation_phase", init: bool = True, clear_last_node: bool = False, notebook: bool = False
     ) -> None:
         if init: