-
Notifications
You must be signed in to change notification settings - Fork 22
Closed
Description
In the current implementation, the remove_avoided_requirements function removes any packages that contain the substring cmake or patchelf in their name.
As a result, building packages using the py-build-cmake backend is impossible, since pyodide-build refuses to install it (because of the cmake in the package name).
pyodide-build/pyodide_build/pypabuild.py
Lines 115 to 123 in b8bd8d8
| def remove_avoided_requirements( | |
| requires: set[str], avoided_requirements: set[str] | list[str] | |
| ) -> set[str]: | |
| for reqstr in list(requires): | |
| req = Requirement(reqstr) | |
| for avoid_name in set(avoided_requirements): | |
| if avoid_name in req.name.lower(): | |
| requires.remove(reqstr) | |
| return requires |
I suggest using avoid_name == req.name.lower() instead of avoid_name in req.name.lower().
Metadata
Metadata
Assignees
Labels
No labels