Clarify role of filetype Parameter #4706
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julian-smith-artifex-com
force-pushed
the
clarify-filetype
branch
from
f95fb18 to
a22f435
Compare
jamie-lemon
approved these changes
Sep 25, 2025
julian-smith-artifex-com
approved these changes
Sep 25, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restate the role of
filetypewhen opening a document.The most important detail is removing the statement that a specified filetype will be cross-checked with the resulting document type after opening: this is wrong.
The parameter's only role is to help finding the document type. If MuPDF's file content inspection was successful, filetype will always be ignored.