Skip to content

feat: new iteration pattern/rewrite (take 2) #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 92 commits into
base: main
Choose a base branch
from
Open

feat: new iteration pattern/rewrite (take 2) #232

wants to merge 92 commits into from

Conversation

@tlambert03
Copy link
Member

No description provided.

@tlambert03
refactor: Refactor AxisIterator and TimePlan classes
93099b4 
This commit refactors the AxisIterator and TimePlan classes in the example.py file. The changes include:
- Adding type hints and annotations to improve code readability and maintainability.
- Renaming the `length` method in AxisIterator to `num_timepoints` for clarity.
- Adding a new `deltas` method to TimePlan to iterate over the time deltas between timepoints.
- Handling the case of an infinite sequence in the `num_timepoints` method of TimePlan.

These changes improve the overall structure and functionality of the code.
@tlambert03
add should_skip and create_event_kwargs patterns
1847b56
@tlambert03
wip
602a05d
@tlambert03
wip: decent, need to decide about should_skip and merging of event va…
a164b76 
…lues
@tlambert03
small fixes
a499420
@tlambert03
wip
6836adc
@tlambert03
better merge
96fd032
@tlambert03
wip
4208b59
@tlambert03
stupid wip
e9ffd5e
@tlambert03
pattern1
1fd9267
@tlambert03
wip
875713e
@tlambert03
updates
af4040f
@tlambert03
updates
7418037
@tlambert03
misc
fbf5376
@tlambert03
Merge branch 'main' into new-iterator-pattern
d73e4b0
@tlambert03
wip
74fecb0
@tlambert03
update tests
02c1d42
@tlambert03
test infinite iter
b881a03
@tlambert03
wip
b6cf368
@tlambert03
wip
f8bea3f
@tlambert03
remove more
bc42f64
@tlambert03
MDASeq
48955b9
@tlambert03
break apart
fb1db42
@tlambert03
rm x
d0782a0
@tlambert03
rm axis iterable
4c130d0
@tlambert03
rename v2
3280c75
@codecov
Copy link

codecov bot commented May 24, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 93.53779% with 59 lines in your changes missing coverage. Please review.

Project coverage is 95.78%. Comparing base (1f5ba81) to head (56fd774).

Files with missing lines Patch % Lines
src/useq/v2/_importable_object.py 64.10% 14 Missing ⚠️
src/useq/v2/_axes_iterator.py 92.79% 8 Missing ⚠️
src/useq/v2/_position.py 85.41% 7 Missing ⚠️
src/useq/v2/_grid.py 96.05% 6 Missing ⚠️
src/useq/v2/_mda_sequence.py 96.47% 5 Missing ⚠️
src/useq/v2/_stage_positions.py 86.48% 5 Missing ⚠️
src/useq/v2/_transformers.py 94.82% 3 Missing ⚠️
src/useq/_mda_event.py 94.44% 2 Missing ⚠️
src/useq/_time.py 94.44% 2 Missing ⚠️
src/useq/v2/_multi_point.py 92.59% 2 Missing ⚠️
... and 4 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #232      +/-   ##
==========================================
- Coverage   97.18%   95.78%   -1.40%     
==========================================
  Files          19       33      +14     
  Lines        1383     2207     +824     
==========================================
+ Hits         1344     2114     +770     
- Misses         39       93      +54

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

tlambert03 added 30 commits May 26, 2025 12:16
@tlambert03
small typing fix
fc10a44
@tlambert03
move shutter tests
8676e22
@tlambert03
add keep shutter open
be078d8
@tlambert03
Merge branch 'main' into refactor/multi-axis-sequence
36a9b9c
@tlambert03
merge in test format
0d2a845
@tlambert03
wip
c8927f6
@tlambert03
fix: set priority for AutoFocusTransform and update test for reset_ev…
0317f0b 
…ent_timer
@tlambert03
minimize case duplication
956373e
@tlambert03
dedupe
edb79f0
@tlambert03
work for py3.9
4eadcb8
@tlambert03
add broken test
22ca36a
@tlambert03
wip
77d8cda
@tlambert03
refactor
0715375
@tlambert03
fix: set event.sequence to None in MDASequence tests
7c28258
@tlambert03
fix test, make immuatable again
2175138
@tlambert03
fix older
088c1af
@tlambert03
bump min pydantic
943bbe2
@tlambert03
more coverage
c5f5cbc
@tlambert03
update lock
77fe0bd
@tlambert03
docs
7b88f2d
@tlambert03
move all names to v2
cd6ed2f
@tlambert03
start reducing duplication
403b017
@tlambert03
rename method
a97ad98
@tlambert03
combine z
7e1874c
@tlambert03
merge time implementations
3107243
@tlambert03
fix: correct typo in usage notes for axes iterator documentation
8cc4e1a
@tlambert03
add MutableMDAEvent
78c029a
@tlambert03
add mutable mda event
71e298c
@tlambert03
refactor: update MutableMDAEvent and MDAEvent classes for improved se…
903b904 
…rialization and validation
@tlambert03
Merge branch 'main' into refactor/multi-axis-sequence
56fd774
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@tlambert03