Skip to content

Commit bccafc0

Browse files
authored
chore: silence JSII deprecated Node.js version warnings in PR builds (aws#35760)
### Reason for this change JSII is emitting deprecated Node.js version warnings during PR builds, which creates noise in the build logs and may cause confusion. Suppressing the warnings is okay. We will deal with this upgrade as part of our SOP to deprecate Node 18 support later in the year. ### Description of changes Added `JSII_SILENCE_WARNING_DEPRECATED_NODE_VERSION: true` environment variable to both PR build workflows: - `.github/workflows/codebuild-pr-build.yml` - `.github/workflows/pr-build.yml` This suppresses the deprecated Node.js version warnings from JSII without affecting functionality. ### Describe any new or updated permissions being added No new permissions required. ### Description of how you validated changes This change only adds an environment variable to silence warnings and doesn't affect build functionality. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
1 parent 4cf6a7b commit bccafc0

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

.github/workflows/codebuild-pr-build.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ jobs:
3030

3131
env:
3232
PR_BUILD: true
33+
JSII_SILENCE_WARNING_DEPRECATED_NODE_VERSION: true
3334

3435
steps:
3536
- name: Checkout code

.github/workflows/pr-build.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ jobs:
2525

2626
env:
2727
PR_BUILD: true
28+
JSII_SILENCE_WARNING_DEPRECATED_NODE_VERSION: true
2829

2930
steps:
3031
- name: Checkout code

0 commit comments

Comments
 (0)