Skip to content

Commit 2218395

Browse files
committed
Fix crash for consider-using-assignment-expr
1 parent 133681e commit 2218395

File tree

3 files changed

+10
-1
lines changed

3 files changed

+10
-1
lines changed
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
Fix crash for ``consider-using-assignment-expr`` when a variable annotation without assignment
2+
is used as the ``if`` test expression.
3+
4+
Closes #10707

pylint/extensions/code_style.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -314,7 +314,7 @@ def _check_prev_sibling_to_if_stmt(
314314
case nodes.Assign(
315315
targets=[nodes.AssignName(name=target_name)]
316316
) | nodes.AnnAssign(target=nodes.AssignName(name=target_name)):
317-
return target_name == name # type: ignore[no-any-return]
317+
return target_name == name and prev_sibling.value is not None # type: ignore[no-any-return]
318318
return False
319319

320320
@staticmethod

tests/functional/ext/code_style/cs_consider_using_assignment_expr.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -157,3 +157,8 @@ class A:
157157
A.var = 2
158158
if A.var:
159159
...
160+
161+
162+
i: int
163+
if i: # pylint: disable=used-before-assignment
164+
pass

0 commit comments

Comments
 (0)