Fix boolean evaluation (#664)

* Remove queue length function

* Always return bool

Author: jan-janssen

executorlib/executor/base.py

@@ -112,6 +112,15 @@ def __len__(self) -> int:
         """
         return len(self._task_scheduler)
 
+    def __bool__(self):
+        """
+        Overwrite length to always return True
+
+        Returns:
+            bool: Always return True
+        """
+        return True
+
     def __exit__(self, *args, **kwargs) -> None:
         """
         Exit method called when exiting the context manager.

tests/test_integration_pyiron_workflow.py

@@ -76,6 +76,7 @@ def slowly_returns_dynamic(dynamic_arg):
 
         dynamic_dynamic = slowly_returns_dynamic()
         executor = SingleNodeExecutor(block_allocation=True, max_workers=1)
+        self.assertTrue(executor)
         cloudpickle_register(ind=1)
         dynamic_object = does_nothing()
         fs = executor.submit(dynamic_dynamic.run, dynamic_object)
@@ -106,6 +107,7 @@ def slowly_returns_42():
             dynamic_42.result, msg="Just a sanity check that the test is set up right"
         )
         executor = SingleNodeExecutor(block_allocation=True, max_workers=1)
+        self.assertTrue(executor)
         cloudpickle_register(ind=1)
         fs = executor.submit(dynamic_42.run)
         fs.add_done_callback(dynamic_42.process_result)
@@ -137,6 +139,7 @@ def returns_42():
             msg="Sanity check that the test starts in the expected condition",
         )
         executor = SingleNodeExecutor(block_allocation=True, max_workers=1)
+        self.assertTrue(executor)
         cloudpickle_register(ind=1)
         fs = executor.submit(dynamic_42.run)
         fs.add_done_callback(dynamic_42.process_result)
@@ -161,6 +164,7 @@ def raise_error():
 
         re = raise_error()
         executor = SingleNodeExecutor(block_allocation=True, max_workers=1)
+        self.assertTrue(executor)
         cloudpickle_register(ind=1)
         fs = executor.submit(re.run)
         with self.assertRaises(
@@ -191,6 +195,7 @@ def slowly_returns_dynamic():
 
         dynamic_dynamic = slowly_returns_dynamic()
         executor = SingleNodeExecutor(block_allocation=True, max_workers=1)
+        self.assertTrue(executor)
         cloudpickle_register(ind=1)
         fs = executor.submit(dynamic_dynamic.run)
         self.assertIsInstance(
@@ -220,6 +225,7 @@ def slow():
 
         f = slow()
         executor = SingleNodeExecutor(block_allocation=True, max_workers=1)
+        self.assertTrue(executor)
         cloudpickle_register(ind=1)
         fs = executor.submit(f.run)
         self.assertEqual(

tests/test_singlenodeexecutor_cache.py

@@ -24,6 +24,7 @@ class TestCacheFunctions(unittest.TestCase):
     def test_cache_data(self):
         cache_directory = "./cache"
         with SingleNodeExecutor(cache_directory=cache_directory) as exe:
+            self.assertTrue(exe)
             future_lst = [exe.submit(sum, [i, i]) for i in range(1, 4)]
             result_lst = [f.result() for f in future_lst]
 
@@ -36,6 +37,7 @@ def test_cache_data(self):
     def test_cache_error(self):
         cache_directory = "./cache_error"
         with SingleNodeExecutor(cache_directory=cache_directory) as exe:
+            self.assertTrue(exe)
             cloudpickle_register(ind=1)
             f = exe.submit(get_error, a=1)
             with self.assertRaises(ValueError):