Improved error handling (#620)

Author: jan-janssen

executorlib/backend/interactive_parallel.py

@@ -80,7 +80,7 @@ def main() -> None:
                 if mpi_rank_zero:
                     interface_send(
                         socket=socket,
-                        result_dict={"error": error, "error_type": str(type(error))},
+                        result_dict={"error": error},
                     )
             else:
                 # Send output

executorlib/backend/interactive_serial.py

@@ -56,7 +56,7 @@ def main(argument_lst: Optional[list[str]] = None):
             except Exception as error:
                 interface_send(
                     socket=socket,
-                    result_dict={"error": error, "error_type": str(type(error))},
+                    result_dict={"error": error},
                 )
             else:
                 # Send output

executorlib/standalone/interactive/communication.py

@@ -47,8 +47,7 @@ def receive_dict(self) -> dict:
         if "result" in output:
             return output["result"]
         else:
-            error_type = output["error_type"].split("'")[1]
-            raise eval(error_type)(output["error"])
+            raise output["error"]
 
     def send_and_receive_dict(self, input_dict: dict) -> dict:
         """
@@ -181,7 +180,7 @@ def interface_send(socket: Optional[zmq.Socket], result_dict: dict):
 
     Args:
         socket (zmq.Socket): socket for the connection
-        result_dict (dict): dictionary to be sent, supported keys are result, error and error_type.
+        result_dict (dict): dictionary to be sent, supported keys are result and error.
     """
     if socket is not None:
         socket.send(cloudpickle.dumps(result_dict))

tests/test_backend_interactive_serial.py

@@ -52,7 +52,7 @@ def test_main_as_thread_error(self):
         t.start()
         submit_error(socket=socket)
         self.assertEqual(
-            cloudpickle.loads(socket.recv())["error_type"], "<class 'TypeError'>"
+            str(type(cloudpickle.loads(socket.recv())["error"])), "<class 'TypeError'>"
         )
         self.assertEqual(cloudpickle.loads(socket.recv()), {"result": True})
         socket.close()
@@ -78,7 +78,7 @@ def test_submit_as_thread_error(self):
         t.start()
         main(argument_lst=["--zmqport", str(port)])
         self.assertEqual(
-            cloudpickle.loads(socket.recv())["error_type"], "<class 'TypeError'>"
+            str(type(cloudpickle.loads(socket.recv())["error"])), "<class 'TypeError'>"
         )
         self.assertEqual(cloudpickle.loads(socket.recv()), {"result": True})
         socket.close()