gui-installer: try to avoid running browser as root

Author: pyhalov

usr/src/cmd/gui-install/src/welcome-screen.c

@@ -29,13 +29,19 @@
 
 #include <glib/gi18n.h>
 #include <gtk/gtk.h>
+#include <stdlib.h>
+#include <sys/types.h>
+#include <sys/wait.h>
+#include <unistd.h>
 #include "callbacks.h"
 #include "installation-profile.h"
 #include "interface-globals.h"
 #include "window-graphics.h"
 #include "welcome-screen.h"
 #include "help-dialog.h"
 
+#define XDG_OPEN "/usr/bin/xdg-open"
+
 /*
  * Signal handler connected up by Glade XML signal autoconnect
  * for the release notes button clicked event.
@@ -46,19 +52,45 @@ on_releasenotesbutton_clicked(GtkWidget *widget,
 {
 	GError *error = NULL;
 	gboolean result;
+	uid_t suid;
+	int pid;
+
+	result = FALSE;
+	/* The installer will typically be run as root under sudo,
+           but we don't want to run browser as root */
+
+	suid = geteuid();
+	if (suid == 0) {
+		char *sudo_uid;
+
+		sudo_uid = getenv("SUDO_UID");
+		if (sudo_uid)
+			suid = strtol(sudo_uid, (char**)NULL, 10);
+	}
+	pid = fork();
+	if (pid == 0) {
+		if (suid > 0 && suid != geteuid())
+			setuid(suid);
+		
+		execl(XDG_OPEN, XDG_OPEN, RELEASENOTESURL, (char *)0);
+		exit(-1);
+	} else if (pid > 0) {
+		int status;
+
+		waitpid(pid, &status, 0);
+		if (WIFEXITED(status) && WEXITSTATUS(status) == 0) {
+			result = TRUE;
+		}
+	}
 
-	result = gtk_show_uri(gtk_widget_get_screen(widget),
-		RELEASENOTESURL,
-		GDK_CURRENT_TIME,
-		&error);
 	if (result != TRUE) {
 		gui_install_prompt_dialog(
 			FALSE,
 			FALSE,
 			FALSE,
 			GTK_MESSAGE_ERROR,
 			_("Unable to display release notes"),
-			error->message);
+			NULL);
 		g_error_free(error);
 	}
 	return (TRUE);