Add get_duck_array to AbstractArray

Clean up short_array_repr.

Author: dcherian

xarray/core/common.py

@@ -155,6 +155,9 @@ def __complex__(self: Any) -> complex:
     def __array__(self: Any, dtype: DTypeLike = None) -> np.ndarray:
         return np.asarray(self.values, dtype=dtype)
 
+    def get_duck_array(self):
+        return self.data
+
     def __repr__(self) -> str:
         return formatting.array_repr(self)
 

xarray/core/formatting.py

@@ -517,14 +517,9 @@ def limit_lines(string: str, *, limit: int):
 
 
 def short_array_repr(array):
-    from .dataarray import DataArray
-    from .variable import Variable
+    from .common import AbstractArray
 
-    if isinstance(array, DataArray):
-        array = array._variable.data
-    if isinstance(array, Variable):
-        array = array.data
-    if isinstance(array, ExplicitlyIndexed):
+    if isinstance(array, (ExplicitlyIndexed, AbstractArray)):
         array = array.get_duck_array()
     if not is_duck_array(array):
         array = np.asarray(array)