pass sse_read_timeout to MCP ClientSession read_timeout_seconds #2240
+102
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DouweM
requested changes
Jul 18, 2025
pydantic_ai_slim/pydantic_ai/mcp.py
Outdated
| @@ -59,6 +60,7 @@ class MCPServer(AbstractToolset[Any], ABC): | |||
| log_level: mcp_types.LoggingLevel | None = None | |||
| log_handler: LoggingFnT | None = None | |||
| timeout: float = 5 | |||
| sse_read_timeout: float = 5 * 60 | |||
There was a problem hiding this comment.
Can we call this read_timeout as it's not SSE specific anymore? We'd still want to keep the sse_read_timeout argument on constructor to _MCPServerHTTP subclasses for backward compatibility, but we can set the new property and print a deprecation warning. We'd likely need to define a custom __init__ and pass init=False to @dataclass.
Let me know if you'd like some more guidance!
There was a problem hiding this comment.
Sounds good, thanks for reviewing.
I mapped sse_read_timeout to read_timeout and added a deprecation warning. I also updated the tests. Let me know if I misused the dataclass setup -- still learning the python way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2222