feat: add MoonshotAI provider with Kimi-K2 model support #2211

zachmayer · 2025-07-15T20:19:41Z

This PR adds a new MoonshotAI provider for Kimi models.

Related PRs:

feat: update OpenAI models - add o1-pro, o3-pro, o3-deep-research, computer-use #2234 - OpenAI model updates (o1-pro, o3-pro, etc.)
Add grok-4 and groq kimi-k2 models #2235 - Grok-4 and Groq Kimi-K2 models

Changes

Add MoonshotAIProvider with OpenAI-compatible API
Implements OpenAI-style interface with custom base URL (api.moonshot.ai)
Supports tool definitions but disables strict tool validation (as per MoonshotAI docs)
Add moonshotai:kimi-k2-0711-preview as known model
Configure to use OpenAIModel for compatibility
Add comprehensive tests for provider functionality
Update CLI and model name tests
Uses MOONSHOT_API_KEY environment variable

The provider follows the same pattern as other OpenAI-compatible providers like DeepSeek and Grok.

As requested by @DouweM, I've split the original large PR into 3 focused PRs for easier review.

pydantic_ai_slim/pydantic_ai/models/__init__.py

zachmayer · 2025-07-16T15:38:10Z

@DouweM @Kludex I think this is ready for review. I'd be happy to split it up into several PRs if you like (or squash the commits!)

DouweM · 2025-07-16T21:41:03Z

@zachmayer Thanks Zach! As you suggested, can you please split this up into separate PRs so the more straightforward ones can be merged more quickly? Pretty commit history is not that important, we'll end up squashing on merge anyway.

Also, from the MoonshotAIProvider, "Please note that the current version of Kimi API does not support the tool_choice=required parameter." makes me think we'll need a new field on OpenAIModelProfile to stop sending that value in this case and prevent errors. They suggest "you can emphasize the use of a certain tool in the prompt to achieve a similar effect" as a workaround, so I wonder if the default "The final response which ends this conversation" description of the output tool that we require to be called is already sufficient.

Maybe we can keep this PR for the MoonshotAIProvider as I already started talking about it :)

- Add MoonshotAIProvider with OpenAI-compatible API - Implements OpenAI-style interface with custom base URL - Supports tool definitions but not strict tool validation - Add moonshotai:kimi-k2-0711-preview as known model - Configure to use OpenAIModel for compatibility - Add comprehensive tests for provider functionality - Update CLI and model name tests

zachmayer · 2025-07-17T14:54:14Z

I made 2 PRs:

pydantic_ai_slim/pydantic_ai/providers/moonshotai.py

DouweM

@zachmayer Thank you! In addition to these comments, can you please add some docs?

pydantic_ai_slim/pydantic_ai/models/openai.py

pydantic_ai_slim/pydantic_ai/providers/moonshotai.py

tests/models/test_model_names.py

hyperlint-ai · 2025-07-17T17:00:57Z

PR Change Summary

Added a new MoonshotAI provider to support Kimi-K2 models, enhancing compatibility with OpenAI's API.

Introduced MoonshotAIProvider with OpenAI-compatible API
Implemented support for Kimi-K2 model
Added comprehensive tests for provider functionality
Updated CLI and model name tests

Modified Files

docs/models/openai.md

How can I customize these reviews?

Check out the Hyperlint AI Reviewer docs for more information on how to customize the review.

If you just want to ignore it on this PR, you can add the hyperlint-ignore label to the PR. Future changes won't trigger a Hyperlint review.

Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add hyperlint-ignore to the PR to ignore the link check for this PR.

zachmayer · 2025-07-17T17:02:05Z

I added a moonshot example to the open ai docs

pydantic_ai_slim/pydantic_ai/providers/moonshotai.py

DouweM · 2025-07-17T18:18:36Z

pydantic_ai_slim/pydantic_ai/providers/moonshotai.py

+
+        # As the MoonshotAI API is OpenAI-compatible, let's assume we also need OpenAIJsonSchemaTransformer,
+        # unless json_schema_transformer is set explicitly.
+        # Also, MoonshotAI does not support strict tool definitions


Is this actually the case or was it just a misinterpretation of the tool_choice=required thing? If so, we can drop this from the comment and drop the field

Looking at their docs:

https://platform.moonshot.ai/docs/guide/use-json-mode-feature-of-kimi-api

https://platform.moonshot.ai/docs/api/chat?utm_source=chatgpt.com#request-body

When you set response_format to {"type": "json_object"}, you must explicitly guide the model to output JSON-formatted content in the prompt and specify the exact format of the JSON, otherwise it may result in unexpected outcomes.

My reading of this is that they don't support strict: mode. You can ask it for a json object, but you need to verybally describe the fields you want in the object.

oh hmmm, this parameter is different than strict for output schemas though. Now I'm not sure.

Ah look like they don't support the json_schema response_format, just json_object, so we can set supports_json_object_output to True (they're both False by default).

I don't see anything about strict on tool definitions though, so I think we can drop that.

pydantic_ai_slim/pydantic_ai/models/openai.py

pydantic_ai_slim/pydantic_ai/providers/moonshotai.py

DouweM

Can you look at the merge conflict as well please?

DouweM · 2025-07-18T14:35:50Z

pydantic_ai_slim/pydantic_ai/providers/moonshotai.py

+
+        # As the MoonshotAI API is OpenAI-compatible, let's assume we also need OpenAIJsonSchemaTransformer,
+        # unless json_schema_transformer is set explicitly.
+        # Also, MoonshotAI does not support strict tool definitions


Ah look like they don't support the json_schema response_format, just json_object, so we can set supports_json_object_output to True (they're both False by default).

I don't see anything about strict on tool definitions though, so I think we can drop that.

DouweM · 2025-07-18T14:36:22Z

pydantic_ai_slim/pydantic_ai/providers/moonshotai.py

+)
+from pydantic_ai.providers import Provider
+
+MoonshotModelName = Literal[


For consistency with the provider class:

Suggested change

MoonshotModelName = Literal[

MoonshotAIModelName = Literal[

zachmayer mentioned this pull request Jul 15, 2025

Official Support For XAI models (namely Grok 4) #2187

Closed

zachmayer commented Jul 16, 2025

View reviewed changes

pydantic_ai_slim/pydantic_ai/models/__init__.py Outdated Show resolved Hide resolved

zachmayer marked this pull request as draft July 16, 2025 14:55

zachmayer marked this pull request as ready for review July 16, 2025 15:36

zachmayer changed the title ~~feat: add o3-pro, grok-4, kimi-k2 model names~~ feat: add o3-pro, grok-4, kimi-k2 Jul 16, 2025

DouweM self-assigned this Jul 16, 2025

This was referenced Jul 17, 2025

feat: update OpenAI models - add o1-pro, o3-pro, o3-deep-research, computer-use #2234

Merged

Add grok-4 and groq kimi-k2 models #2235

Merged

feat: add MoonshotAI provider with Kimi-K2 model support #2236

Closed

zachmayer force-pushed the feat/add-kimi-grok-o3pro-clean branch from 4c4ebf7 to dcd7d87 Compare July 17, 2025 14:13

zachmayer changed the title ~~feat: add o3-pro, grok-4, kimi-k2~~ feat: add MoonshotAI provider with Kimi-K2 model support Jul 17, 2025

Merge branch 'main' into feat/add-kimi-grok-o3pro-clean

ab62dba

remove one change

390b2f8

zachmayer commented Jul 17, 2025

View reviewed changes

pydantic_ai_slim/pydantic_ai/providers/moonshotai.py Show resolved Hide resolved

Merge branch 'main' into feat/add-kimi-grok-o3pro-clean

b9ccddc

DouweM requested changes Jul 17, 2025

View reviewed changes

DouweM added the awaiting author revision label Jul 17, 2025

zachmayer added 2 commits July 17, 2025 11:39

fix-test

5ac96cf

respond to PR feedback

3bb2886

zachmayer commented Jul 17, 2025

View reviewed changes

pydantic_ai_slim/pydantic_ai/providers/moonshotai.py Show resolved Hide resolved

zachmayer added 2 commits July 17, 2025 13:04

one more assert

7360d6e

all moonshot models

9e6db4f

DouweM requested changes Jul 17, 2025

View reviewed changes

Merge branch 'main' into feat/add-kimi-grok-o3pro-clean

15255cd

zachmayer and others added 4 commits July 17, 2025 21:55

Merge branch 'main' into feat/add-kimi-grok-o3pro-clean

0853043

newline

5e67bac

pr feedback and test fix

befbef1

undo-change

fa81e0f

DouweM requested changes Jul 18, 2025

View reviewed changes

feat: add MoonshotAI provider with Kimi-K2 model support #2211

Are you sure you want to change the base?

feat: add MoonshotAI provider with Kimi-K2 model support #2211

Uh oh!

Conversation

zachmayer commented Jul 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Uh oh!

Uh oh!

zachmayer commented Jul 16, 2025

Uh oh!

DouweM commented Jul 16, 2025

Uh oh!

zachmayer commented Jul 17, 2025

Uh oh!

Uh oh!

DouweM left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hyperlint-ai bot commented Jul 17, 2025

PR Change Summary

Uh oh!

zachmayer commented Jul 17, 2025

Uh oh!

Uh oh!

DouweM Jul 17, 2025

Choose a reason for hiding this comment

Uh oh!

zachmayer Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

zachmayer Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

DouweM Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

DouweM left a comment

Choose a reason for hiding this comment

Uh oh!

DouweM Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

DouweM Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

zachmayer commented Jul 15, 2025 •

edited

Loading