Skip to content

Commit 0b6e169

Browse files
Change default method in Location.get_sun_rise_set_transit (#2410)
* Change default method in Location.get_sun_rise_set_transit * Update v0.11.3.rst * Update docs/sphinx/source/whatsnew/v0.11.3.rst Co-authored-by: Kevin Anderson <[email protected]> --------- Co-authored-by: Kevin Anderson <[email protected]>
1 parent c18c796 commit 0b6e169

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

docs/sphinx/source/whatsnew/v0.11.3.rst

+2
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@ Breaking Changes
2020
Use :py:func:`~pvlib.spectrum.spectral_factor_firstsolar` instead. (:issue:`2130`, :pull:`2131`)
2121
* Remove deprecated :py:func:`!pvlib.spectrum.get_am15g` function; use
2222
:py:func:`~pvlib.spectrum.get_reference_spectra` instead. (:pull:`2409`)
23+
* Change default method of :py:func:`~pvlib.location.Location.get_sun_rise_set_transit`
24+
to ``'spa'`` instead of ``'pyephem'``. (:pull:`2410`)
2325

2426
Bug fixes
2527
~~~~~~~~~

pvlib/location.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -368,15 +368,15 @@ def get_airmass(self, times=None, solar_position=None,
368368

369369
return airmass
370370

371-
def get_sun_rise_set_transit(self, times, method='pyephem', **kwargs):
371+
def get_sun_rise_set_transit(self, times, method='spa', **kwargs):
372372
"""
373373
Calculate sunrise, sunset and transit times.
374374
375375
Parameters
376376
----------
377377
times : DatetimeIndex
378378
Must be localized to the Location
379-
method : str, default 'pyephem'
379+
method : str, default 'spa'
380380
'pyephem', 'spa', or 'geometric'
381381
382382
kwargs :

0 commit comments

Comments
 (0)