Adding tests for non-dynamic presence channels

Author: Collin Dauphinee

PusherClient.Tests.Utilities/FakeAuthoriser.cs

@@ -21,7 +21,7 @@ public string Authorize(string channelName, string socketId)
             {
                 var channelData = new PresenceChannelData();
                 channelData.user_id = socketId;
-                channelData.user_info = new { name = _userName };
+                channelData.user_info = new FakeUserInfo { name = _userName };
 
                 authData = provider.Authenticate(channelName, socketId, channelData).ToJson();
             }

PusherClient.Tests.Utilities/FakeUserInfo.cs

@@ -0,0 +1,9 @@
+using PusherServer;
+
+namespace PusherClient.Tests.Utilities
+{
+    public class FakeUserInfo
+    {
+        public string name { get; set; }
+    }
+}

PusherClient.Tests.Utilities/PusherClient.Tests.Utilities.csproj

@@ -69,6 +69,7 @@
   <ItemGroup>
     <Compile Include="ChannelNameFactory.cs" />
     <Compile Include="Config.cs" />
+    <Compile Include="FakeUserInfo.cs" />
     <Compile Include="FakeAuthoriser.cs" />
     <Compile Include="Properties\AssemblyInfo.cs" />
     <Compile Include="PusherFactory.cs" />

PusherClient.Tests/AcceptanceTests/PresenceChannel.cs

@@ -92,5 +92,49 @@ public void PresenceChannelShouldAddAMemberWhenGivenAMemberAsync()
             Assert.IsTrue(channel.IsSubscribed);
             Assert.IsTrue(channelSubscribed);
         }
+
+        [Test]
+        public void PresenceChannelShouldUseGenericWhenGivenAMemberAsync()
+        {
+            // Arrange
+            var stubOptions = new PusherOptions
+            {
+                Authorizer = new FakeAuthoriser(UserNameFactory.CreateUniqueUserName())
+            };
+
+            var pusher = PusherFactory.GetPusher(stubOptions);
+            AutoResetEvent reset = new AutoResetEvent(false);
+
+            pusher.Connected += sender =>
+            {
+                reset.Set();
+            };
+
+            AsyncContext.Run(() => pusher.ConnectAsync());
+            reset.WaitOne(TimeSpan.FromSeconds(5));
+            reset.Reset();
+
+            var mockChannelName = ChannelNameFactory.CreateUniqueChannelName(presenceChannel: true);
+
+            var channelSubscribed = false;
+
+            // Act
+            var channel = AsyncContext.Run(() => pusher.SubscribePresenceAsync<FakeUserInfo>(mockChannelName));
+            channel.Subscribed += sender =>
+            {
+                channelSubscribed = true;
+                reset.Set();
+            };
+
+            reset.WaitOne(TimeSpan.FromSeconds(10));
+
+            // Assert
+            Assert.IsNotNull(channel);
+            StringAssert.Contains(mockChannelName, channel.Name);
+            Assert.IsTrue(channel.IsSubscribed);
+            Assert.IsTrue(channelSubscribed);
+
+            CollectionAssert.IsNotEmpty(channel.Members);
+        }
     }
 }

PusherClient.Tests/UnitTests/PusherTests.cs

@@ -1,6 +1,7 @@
 using System;
 using Nito.AsyncEx;
 using NUnit.Framework;
+using PusherClient.Tests.Utilities;
 
 namespace PusherClient.Tests.UnitTests
 {
@@ -147,5 +148,51 @@ public void PusherShouldThrowAnExceptionWhenSubscribeIsCalledWithANullStringForA
             Assert.IsNotNull(caughtException);
             StringAssert.Contains("The channel name cannot be null or whitespace", caughtException.Message);
         }
+
+        [Test]
+        public void PusherShouldThrowAnExceptionWhenSubscribePresenceIsCalledWithANonPresenceChannelAsync()
+        {
+            // Arrange
+            ArgumentException caughtException = null;
+
+            // Act
+            try
+            {
+                var pusher = new Pusher("FakeAppKey");
+                var channel = AsyncContext.Run(() => pusher.SubscribePresenceAsync<string>("private-123"));
+            }
+            catch (ArgumentException ex)
+            {
+                caughtException = ex;
+            }
+
+            // Assert
+            Assert.IsNotNull(caughtException);
+            StringAssert.Contains("The channel name must be refer to a presence channel", caughtException.Message);
+        }
+
+        [Test]
+        public void PusherShouldThrowAnExceptionWhenSubscribePresenceIsCalledWithADifferentTypeAsync()
+        {
+            // Arrange
+            InvalidOperationException caughtException = null;
+
+            // Act
+            var pusher = new Pusher("FakeAppKey", new PusherOptions { Authorizer = new FakeAuthoriser("test") });
+            AsyncContext.Run(() => pusher.SubscribePresenceAsync<string>("presence-123"));
+
+            try
+            {
+                AsyncContext.Run(() => pusher.SubscribePresenceAsync<int>("presence-123"));
+            }
+            catch (InvalidOperationException ex)
+            {
+                caughtException = ex;
+            }
+
+            // Assert
+            Assert.IsNotNull(caughtException);
+            StringAssert.Contains("Cannot change channel member type; was previously defined as", caughtException.Message);
+        }
     }
 }