-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Match query params with hash-based routing #73
Comments
There's nothing wrong with have a query-looking part in the anchor, it's perfectly valid according to RFC 3986, it's just that it won't be part of the actual query, it'll be part of the "fragment" (anchor) instead. So |
From the spec:
So you can see from the ebnf there that |
Would it be worth noting the ordering restriction in the guide? For example, we don't want users struggling with trying to figure out how to parse this with hash-based routing:
|
I don't think so... it seems pretty clear to me that hash based routing only deals with things after the |
Actually, if it tripped you up, I'm wrong in that assumption, and adding a note certainly wouldn't do any harm. |
I don't think this is possible with properly formatted URLs, since the query param should come before the anchor tag.
https://stackoverflow.com/questions/12682952/proper-url-forming-with-query-string-and-anchor-hashtag
Sure, you can get this working with incorrectly-formatted URLs (query after anchor), but other sites are unlikely to present the URL this way (e.g. github OAuth).
Should I add a note about this in the guide?
The text was updated successfully, but these errors were encountered: