Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a example #48

Open
jimmyhuco opened this issue Nov 2, 2017 · 3 comments
Open

Add a example #48

jimmyhuco opened this issue Nov 2, 2017 · 3 comments

Comments

@jimmyhuco
Copy link

After upgrading Aff to 4.0.0, something has broken.

I think adding a example to demo routing in Halogen App is a good idea.

Powered By Halogen 3.0.1

@krisajenkins
Copy link
Contributor

krisajenkins commented Nov 24, 2017

+1. I found that matchesAff no longer works the way it used to. I couldn't figure out what was broken, but FWIW I worked around it by subscribing to matches directly with something like this:

routing :: Routes
routing = ...

routeProducer ::
  forall eff. Producer Routes (Aff (avar :: AVAR | eff)) Unit
routeProducer = produce \emit -> do
  matches routing $ \old new -> emit $ Left new

@natefaubion
Copy link
Collaborator

@krisajenkins Yeah, that's probably the recommended why if you are using Aff. matchesAff is broken and should have been removed in the previous release. It relies on MonadCont semantics for Aff which hasn't been supported for some time.

@krisajenkins
Copy link
Contributor

Thanks for confirming @natefaubion. :-)

So it seems like this this, #49, #40 and #42 are all the same issue then, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants