Skip to content

change regex API to use Semigroup flags, defaults false #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jamesdbrock opened this issue Mar 22, 2022 · 0 comments · Fixed by #170
Closed

change regex API to use Semigroup flags, defaults false #157

jamesdbrock opened this issue Mar 22, 2022 · 0 comments · Fixed by #170

Comments

@jamesdbrock
Copy link
Member

the default regex should provide no configuration? You can then provide a regexWithFlags version, and partially apply it for the default case regex = flip regexWithFlags (unicode <> dotAll).

On reflection, let's just have all of the flags set to false by default, maybe that’s less surprising.

Originally posted by @jamesdbrock in #153 (comment)
@jamesdbrock jamesdbrock mentioned this issue Apr 1, 2022
Merged
4 tasks
@jamesdbrock jamesdbrock linked a pull request Apr 1, 2022 that will close this issue
New regex parser #170
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

New regex parser purescript-contrib/purescript-parsing
1 participant
@jamesdbrock