(PA-7815) Rubocop changes for pdk template 3.5.1

Author: tvpartytonight

lib/puppet/provider/zone/solaris.rb

@@ -142,7 +142,7 @@ def exec_cmd(var)
     # entire pipeline
     out = execute("echo \"#{var[:input]}\" | #{var[:cmd]}", failonfail: false, combine: true)
     st = $CHILD_STATUS.exitstatus
-    { out: out, exit: st }
+    { out:, exit: st }
   end
 
   # Clear out the cached values.

lib/puppet/type/zone.rb

@@ -118,7 +118,7 @@ def sync
       # everything between it and us.
       self.class.state_sequence(retrieve, should).each do |state|
         method = state[direction]
-        raise Puppet::DevError, _('Cannot move %{direction} from %{name}') % { direction: direction, name: st[:name] } unless method
+        raise Puppet::DevError, _('Cannot move %{direction} from %{name}') % { direction:, name: st[:name] } unless method
         provider_sync_send(method)
       end
 
@@ -323,12 +323,12 @@ def insync?(is)
   def validate_ip(ip, name)
     IPAddr.new(ip) if ip
   rescue ArgumentError
-    raise Puppet::Error, _("'%{ip}' is an invalid %{name}") % { ip: ip, name: name }, $ERROR_INFO
+    raise Puppet::Error, _("'%{ip}' is an invalid %{name}") % ({ ip:, name: }), $ERROR_INFO
   end
 
   def validate_exclusive(interface, address, _router)
     return if !interface.nil? && address.nil?
-    fail _('only interface may be specified when using exclusive IP stack: %{interface}:%{address}') % { interface: interface, address: address }
+    fail _('only interface may be specified when using exclusive IP stack: %{interface}:%{address}') % ({ interface:, address: })
   end
 
   def validate_shared(interface, address, router)

spec/spec_helper_acceptance.rb

@@ -22,7 +22,7 @@ def run_puppet_install_helper
 
     agent_sha = ENV['BEAKER_PUPPET_AGENT_SHA'] || ENV['PUPPET_AGENT_SHA']
     if agent_sha.nil? || agent_sha.empty?
-      install_puppet_agent_on(hosts, options.merge(version: version))
+      install_puppet_agent_on(hosts, options.merge(version:))
     else
       # If we have a development sha, assume we're testing internally
       dev_builds_url = ENV['DEV_BUILDS_URL'] || 'http://builds.delivery.puppetlabs.net'

spec/unit/provider/zone/solaris_spec.rb

@@ -16,7 +16,7 @@
       iptype = instance_double 'Puppet::Property'
       allow(iptype).to receive(:name).and_return(:iptype)
       allow(iptype).to receive(:safe_insync?).with(iptype).and_return(false)
-      allow(provider).to receive(:properties).and_return(iptype: iptype)
+      allow(provider).to receive(:properties).and_return(iptype:)
       allow(resource).to receive(:properties).and_return([iptype])
       resource[:create_args] = 'create_args'
       expect(provider).to receive(:setconfig).with("create -b create_args\nset ip-type=shared")