Bug in 'puppetlabs-yumrepo_core', '3.0.0'

[sahaqaa]

Describe the Bug

When using mod 'puppetlabs-yumrepo_core', '3.0.0' catalog compilation fails

Expected Behavior

When i use mod 'puppetlabs-yumrepo_core', '2.1.0' in my Puppetfile all is ok. When i switch to

mod 'puppetlabs-yumrepo_core', '3.0.0'

catalog compilation fails.

Steps to Reproduce

Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'

Environment

• Version ['puppetlabs-yumrepo_core', '3.0.0']
• Platform [RHEL8, RHEL9]
• Puppetserver is 7.X

Additional Context

template-rhel8 /etc/yum.repos.d # puppet agent -t --noop
Info: Using environment 'manage_microsoft_defender_repo_file_via_puppet'
Info: Retrieving pluginfacts
Info: Retrieving plugin
Info: Loading facts

Notice: Requesting catalog from PUPPET_SERVER_FQDN:8140 (X.X.X.X)
Notice: Catalog compiled by PUPPET_SERVER_FQDN

Error: Could not autoload puppet/provider/yumrepo/inifile: /opt/puppetlabs/puppet/cache/lib/puppet/provider/yumrepo/inifile.rb:253: syntax error, unexpected ','

                    { file:, current_mode: '%03o' % curre...

                           ^

/opt/puppetlabs/puppet/cache/lib/puppet/provider/yumrepo/inifile.rb:253: syntax error, unexpected ',', expecting `end'

...nt_mode: '%03o' % current_mode, target_mode: '%03o' % target...

...                              ^

/opt/puppetlabs/puppet/cache/lib/puppet/provider/yumrepo/inifile.rb:253: syntax error, unexpected '}', expecting `end'

...et_mode: '%03o' % target_mode }

...                              ^

/opt/puppetlabs/puppet/cache/lib/puppet/provider/yumrepo/inifile.rb:408: syntax error, unexpected `end', expecting end-of-input

Error: Could not autoload puppet/type/yumrepo: Could not autoload puppet/provider/yumrepo/inifile: /opt/puppetlabs/puppet/cache/lib/puppet/provider/yumrepo/inifile.rb:253: syntax error, unexpected ','

                    { file:, current_mode: '%03o' % curre...

                           ^

/opt/puppetlabs/puppet/cache/lib/puppet/provider/yumrepo/inifile.rb:253: syntax error, unexpected ',', expecting `end'

...nt_mode: '%03o' % current_mode, target_mode: '%03o' % target...

...                              ^

/opt/puppetlabs/puppet/cache/lib/puppet/provider/yumrepo/inifile.rb:253: syntax error, unexpected '}', expecting `end'

...et_mode: '%03o' % target_mode }

...                              ^

/opt/puppetlabs/puppet/cache/lib/puppet/provider/yumrepo/inifile.rb:408: syntax error, unexpected `end', expecting end-of-input

Error: Failed to apply catalog: Could not autoload puppet/type/yumrepo: Could not autoload puppet/provider/yumrepo/inifile: /opt/puppetlabs/puppet/cache/lib/puppet/provider/yumrepo/inifile.rb:253: syntax error, unexpected ','

                    { file:, current_mode: '%03o' % curre...

                           ^

/opt/puppetlabs/puppet/cache/lib/puppet/provider/yumrepo/inifile.rb:253: syntax error, unexpected ',', expecting `end'

...nt_mode: '%03o' % current_mode, target_mode: '%03o' % target...

...                              ^

/opt/puppetlabs/puppet/cache/lib/puppet/provider/yumrepo/inifile.rb:253: syntax error, unexpected '}', expecting `end'

...et_mode: '%03o' % target_mode }

...                              ^

/opt/puppetlabs/puppet/cache/lib/puppet/provider/yumrepo/inifile.rb:408: syntax error, unexpected `end', expecting end-of-input

template-rhel8 /etc/yum.repos.d #

[bastelfreak]

Since https://github.com/puppetlabs/puppetlabs-yumrepo_core/pull/82/files#diff-4f894049af3375c2bd4e608f546f8d4a0eed95464efcdea850993200db9fef5c , puppet 7.x isn't supported anymore, and I guess that's the version you are using?

[sahaqaa]

Version of Puppetserver is 7.X

But when i check file https://github.com/puppetlabs/puppetlabs-yumrepo_core/blob/main/metadata.json it has requirements:

  "requirements": [
    {
      "name": "puppet",
      "version_requirement": ">= 7.0.0 < 9.0.0"
    }

So i was thinking it should be ok

[bastelfreak]

Relevant is the version of the puppet agent. Puppet 7 is dead since months and Perforce is in the process of removing support for it. In #82 it was just forgotten to update the metadata.json

[sahaqaa]

Ok, thanks

[tvpartytonight]

Sorry for missing that in the update; I'll be sure to fix that in the metadata.

[bastelfreak]

@tvpartytonight is it also possible to fix the release notes? I'm not sure if "(PA-7815) Updates for pdk template 3.5.1" is so helpful for the enduser. Maybe "(PA-7815) Require Puppet 8.x" and label it as breaking change? (that's how we would do it at vox pupuli).

[tvpartytonight]

@bastelfreak I think I am going to have to do a z release of all the core modules affected, as this was a sort of batched effort and it affects all the core modules I just released. I'll make sure it is explicit in that messaging.

[tvpartytonight]

This has been addressed in the 3.0.1 release. Thanks for bringing it to my attention!