(GH-663) Quote Workspace path

jpogran · jpogran · commit e93bb7d7c5b9 · 2020-05-20T11:50:56.000-04:00
This commit fixes a bug that occurs if the workspace path has a space or
other non-standard character. This would cause a command line parsing
error when trying to execute the language server.
diff --git a/src/helpers/commandHelper.ts b/src/helpers/commandHelper.ts
@@ -143,7 +143,8 @@ export class CommandEnvironmentHelper {
 
     args.push('--timeout=' + settings.workspace.editorService.timeout);
     if (vscode.workspace.workspaceFolders !== undefined) {
-      args.push('--local-workspace=' + vscode.workspace.workspaceFolders[0].uri.fsPath);
+      const path = `--local-workspace='${vscode.workspace.workspaceFolders[0].uri.fsPath}'`;
+      args.push(path);
     }
 
     // Convert the individual puppet settings into the --puppet-settings

Original file line number	Diff line number	Diff line change
`@@ -143,7 +143,8 @@ export class CommandEnvironmentHelper {`
`143`	`143`
`144`	`144`	`args.push('--timeout=' + settings.workspace.editorService.timeout);`
`145`	`145`	`if (vscode.workspace.workspaceFolders !== undefined) {`
`146`		`- args.push('--local-workspace=' + vscode.workspace.workspaceFolders[0].uri.fsPath);`
	`146`	+ const path = `--local-workspace='${vscode.workspace.workspaceFolders[0].uri.fsPath}'`;
	`147`	`+ args.push(path);`
`147`	`148`	`}`
`148`	`149`
`149`	`150`	`// Convert the individual puppet settings into the --puppet-settings`