Skip to content

Commit ba86611

Browse files
committed
adding more rubocop warns to TODO
1 parent 84418e0 commit ba86611

File tree

2 files changed

+119
-8
lines changed

2 files changed

+119
-8
lines changed

.rubocop_todo.yml

Lines changed: 117 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,41 @@
11
# This configuration was generated by
22
# `rubocop --auto-gen-config`
3-
# on 2025-06-05 10:57:46 UTC using RuboCop version 1.70.0.
3+
# on 2025-06-05 11:34:36 UTC using RuboCop version 1.70.0.
44
# The point is for the user to remove these configuration records
55
# one by one as the offenses are removed from the code base.
66
# Note that changes in the inspected code, or installation of new
77
# versions of RuboCop, may require this file to be generated again.
88

9+
# Offense count: 4
10+
# This cop supports safe autocorrection (--autocorrect).
11+
Layout/BlockEndNewline:
12+
Exclude:
13+
- 'spec/puppet/resource_api_spec.rb'
14+
915
# Offense count: 4
1016
# This cop supports safe autocorrection (--autocorrect).
1117
Layout/EmptyLineAfterGuardClause:
1218
Exclude:
1319
- 'lib/puppet/resource_api.rb'
1420

21+
# Offense count: 4
22+
# This cop supports safe autocorrection (--autocorrect).
23+
# Configuration parameters: AllowAliasSyntax, AllowedMethods.
24+
# AllowedMethods: alias_method, public, protected, private
25+
Layout/EmptyLinesAroundAttributeAccessor:
26+
Exclude:
27+
- 'spec/puppet/resource_api_spec.rb'
28+
29+
# Offense count: 10
30+
# This cop supports safe autocorrection (--autocorrect).
31+
# Configuration parameters: AllowMultipleStyles, EnforcedHashRocketStyle, EnforcedColonStyle, EnforcedLastArgumentHashStyle.
32+
# SupportedHashRocketStyles: key, separator, table
33+
# SupportedColonStyles: key, separator, table
34+
# SupportedLastArgumentHashStyles: always_inspect, always_ignore, ignore_implicit, ignore_explicit
35+
Layout/HashAlignment:
36+
Exclude:
37+
- 'spec/puppet/resource_api_spec.rb'
38+
1539
# Offense count: 2
1640
# This cop supports safe autocorrection (--autocorrect).
1741
Layout/HeredocIndentation:
@@ -57,6 +81,13 @@ Layout/TrailingEmptyLines:
5781
Exclude:
5882
- 'lib/puppet/resource_api.rb'
5983

84+
# Offense count: 3
85+
# Configuration parameters: AllowedMethods.
86+
# AllowedMethods: enums
87+
Lint/ConstantDefinitionInBlock:
88+
Exclude:
89+
- 'spec/puppet/resource_api_spec.rb'
90+
6091
# Offense count: 19
6192
# Configuration parameters: AllowComments, AllowEmptyLambdas.
6293
Lint/EmptyBlock:
@@ -75,22 +106,65 @@ Lint/EmptyClass:
75106
- 'spec/puppet/resource_api/transport_spec.rb'
76107
- 'spec/puppet/resource_api_spec.rb'
77108

78-
# Offense count: 5
109+
# Offense count: 1
110+
# Configuration parameters: MaximumRangeSize.
111+
Lint/MissingCopEnableDirective:
112+
Exclude:
113+
- 'lib/puppet/resource_api.rb'
114+
115+
# Offense count: 6
79116
# This cop supports safe autocorrection (--autocorrect).
80117
Lint/RedundantCopDisableDirective:
81118
Exclude:
82119
- 'lib/puppet/resource_api.rb'
83120

121+
# Offense count: 1
122+
# Configuration parameters: EnforcedStyle, CheckMethodNames, CheckSymbols, AllowedIdentifiers, AllowedPatterns.
123+
# SupportedStyles: snake_case, normalcase, non_integer
124+
# AllowedIdentifiers: capture3, iso8601, rfc1123_date, rfc822, rfc2822, rfc3339, x86_64
125+
Naming/VariableNumber:
126+
Exclude:
127+
- 'spec/puppet/resource_api_spec.rb'
128+
129+
# Offense count: 1
130+
# This cop supports safe autocorrection (--autocorrect).
131+
# Configuration parameters: EnforcedStyle.
132+
# SupportedStyles: be, be_nil
133+
RSpec/BeNil:
134+
Exclude:
135+
- 'spec/puppet/resource_api_spec.rb'
136+
84137
# Offense count: 25
85138
# Configuration parameters: IgnoredMetadata.
86139
RSpec/DescribeClass:
87140
Enabled: false
88141

142+
# Offense count: 16
143+
# This cop supports safe autocorrection (--autocorrect).
144+
# Configuration parameters: AllowConsecutiveOneLiners.
145+
RSpec/EmptyLineAfterExample:
146+
Exclude:
147+
- 'spec/puppet/resource_api_spec.rb'
148+
89149
# Offense count: 37
90150
# Configuration parameters: CountAsOne.
91151
RSpec/ExampleLength:
92152
Max: 16
93153

154+
# Offense count: 45
155+
# This cop supports safe autocorrection (--autocorrect).
156+
# Configuration parameters: EnforcedStyle.
157+
# SupportedStyles: implicit, each, example
158+
RSpec/HookArgument:
159+
Exclude:
160+
- 'spec/puppet/resource_api_spec.rb'
161+
162+
# Offense count: 1
163+
# This cop supports safe autocorrection (--autocorrect).
164+
RSpec/HooksBeforeExamples:
165+
Exclude:
166+
- 'spec/puppet/resource_api_spec.rb'
167+
94168
# Offense count: 18
95169
# Configuration parameters: AssignmentOnly.
96170
RSpec/InstanceVariable:
@@ -120,6 +194,16 @@ RSpec/MultipleMemoizedHelpers:
120194
RSpec/NestedGroups:
121195
Max: 7
122196

197+
# Offense count: 2
198+
RSpec/RepeatedExampleGroupDescription:
199+
Exclude:
200+
- 'spec/puppet/resource_api_spec.rb'
201+
202+
# Offense count: 2
203+
RSpec/StubbedMock:
204+
Exclude:
205+
- 'spec/puppet/resource_api_spec.rb'
206+
123207
# Offense count: 47
124208
RSpec/SubjectStub:
125209
Exclude:
@@ -139,6 +223,17 @@ RSpec/VerifiedDoubleReference:
139223
- 'spec/puppet/resource_api/type_definition_spec.rb'
140224
- 'spec/puppet/resource_api_spec.rb'
141225

226+
# Offense count: 11
227+
# This cop supports safe autocorrection (--autocorrect).
228+
# Configuration parameters: EnforcedStyle, ProceduralMethods, FunctionalMethods, AllowedMethods, AllowedPatterns, AllowBracesOnProceduralOneLiners, BracesRequiredMethods.
229+
# SupportedStyles: line_count_based, semantic, braces_for_chaining, always_braces
230+
# ProceduralMethods: benchmark, bm, bmbm, create, each_with_object, measure, new, realtime, tap, with_object
231+
# FunctionalMethods: let, let!, subject, watch
232+
# AllowedMethods: lambda, proc, it
233+
Style/BlockDelimiters:
234+
Exclude:
235+
- 'spec/puppet/resource_api_spec.rb'
236+
142237
# Offense count: 1
143238
# This cop supports unsafe autocorrection (--autocorrect-all).
144239
# Configuration parameters: AllowedReceivers.
@@ -169,25 +264,28 @@ Style/HashTransformValues:
169264
Exclude:
170265
- 'lib/puppet/resource_api.rb'
171266

172-
# Offense count: 6
267+
# Offense count: 7
173268
# This cop supports safe autocorrection (--autocorrect).
174269
Style/IfUnlessModifier:
175270
Exclude:
176271
- 'lib/puppet/resource_api.rb'
272+
- 'spec/puppet/resource_api_spec.rb'
177273

178-
# Offense count: 1
274+
# Offense count: 2
179275
# This cop supports safe autocorrection (--autocorrect).
180276
Style/RedundantAssignment:
181277
Exclude:
182278
- 'lib/puppet/resource_api.rb'
279+
- 'spec/puppet/resource_api_spec.rb'
183280

184-
# Offense count: 2
281+
# Offense count: 39
185282
# This cop supports safe autocorrection (--autocorrect).
186283
# Configuration parameters: EnforcedStyle, AllowInnerSlashes.
187284
# SupportedStyles: slashes, percent_r, mixed
188285
Style/RegexpLiteral:
189286
Exclude:
190287
- 'lib/puppet/resource_api.rb'
288+
- 'spec/puppet/resource_api_spec.rb'
191289

192290
# Offense count: 1
193291
# This cop supports unsafe autocorrection (--autocorrect-all).
@@ -215,34 +313,45 @@ Style/SuperArguments:
215313
Exclude:
216314
- 'lib/puppet/resource_api.rb'
217315

218-
# Offense count: 4
316+
# Offense count: 6
219317
# This cop supports safe autocorrection (--autocorrect).
220318
# Configuration parameters: .
221319
# SupportedStyles: percent, brackets
222320
Style/SymbolArray:
223321
EnforcedStyle: percent
224322
MinSize: 5
225323

226-
# Offense count: 1
324+
# Offense count: 4
227325
# This cop supports unsafe autocorrection (--autocorrect-all).
228326
# Configuration parameters: AllowMethodsWithArguments, AllowedMethods, AllowedPatterns, AllowComments.
229327
# AllowedMethods: define_method
230328
Style/SymbolProc:
231329
Exclude:
232330
- 'lib/puppet/resource_api.rb'
331+
- 'spec/puppet/resource_api_spec.rb'
233332

234-
# Offense count: 1
333+
# Offense count: 3
235334
# This cop supports safe autocorrection (--autocorrect).
236335
# Configuration parameters: EnforcedStyleForMultiline.
237336
# SupportedStylesForMultiline: comma, consistent_comma, no_comma
238337
Style/TrailingCommaInArguments:
239338
Exclude:
240339
- 'lib/puppet/resource_api.rb'
340+
- 'spec/puppet/resource_api_spec.rb'
241341

242342
# Offense count: 1
243343
# This cop supports safe autocorrection (--autocorrect).
244344
# Configuration parameters: EnforcedStyleForMultiline.
245345
# SupportedStylesForMultiline: comma, consistent_comma, no_comma
346+
Style/TrailingCommaInArrayLiteral:
347+
Exclude:
348+
- 'spec/puppet/resource_api_spec.rb'
349+
350+
# Offense count: 146
351+
# This cop supports safe autocorrection (--autocorrect).
352+
# Configuration parameters: EnforcedStyleForMultiline.
353+
# SupportedStylesForMultiline: comma, consistent_comma, no_comma
246354
Style/TrailingCommaInHashLiteral:
247355
Exclude:
248356
- 'lib/puppet/resource_api.rb'
357+
- 'spec/puppet/resource_api_spec.rb'

lib/puppet/resource_api.rb

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -545,6 +545,8 @@ def register_transport(schema)
545545
end
546546
module_function :register_transport # rubocop:disable Style/AccessModifierDeclarations
547547

548+
# rubocop:disable Layout/EndOfLine
549+
548550
def self.class_name_from_type_name(type_name)
549551
type_name.to_s.split('_').map(&:capitalize).join
550552
end

0 commit comments

Comments
 (0)