CONT-234 Refactor nested loops

The check iterates over an array of exec commands and then over each token in each command. Prior to this commit, these loops were nested. The goal of this commit is to refactor this to clean up the code a bit. This was achieved by extracting the logic which iterates over the tokens in a command into a function called check_unsafe_interpolations. Separating code logic into functions and removing nested loops improves code readability and should make it easier to build upon in the future.

Author: GSPatton

lib/puppet-lint/plugins/check_unsafe_interpolations.rb

@@ -19,16 +19,20 @@ def check
 
     # Iterate over each command found in any exec
     exec_resources.each do |command_resources|
-      # Iterate over each command in execs and check for unsafe interpolations
-      command_resources[:tokens].each do |token|
-        # We are only interested in tokens from command onwards
-        next unless token.type == :NAME
-        # Don't check the command if it is parameterised
-        next if parameterised?(token)
+      check_unsafe_interpolations(command_resources)
+    end
+  end
 
-        check_command(token).each do |t|
-          notify_warning(t)
-        end
+  # Iterates over tokens in a command and raises a warning if an interpolated variable is found
+  def check_unsafe_interpolations(command_resources)
+    command_resources[:tokens].each do |token|
+      # We are only interested in tokens from command onwards
+      next unless token.type == :NAME
+      # Don't check the command if it is parameterised
+      next if parameterised?(token)
+
+      check_command(token).each do |t|
+        notify_warning(t)
       end
     end
   end