Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any plans 0.7.1 with Redis support #83

Open
sheinbergon opened this issue Nov 8, 2016 · 6 comments
Open

Any plans 0.7.1 with Redis support #83

sheinbergon opened this issue Nov 8, 2016 · 6 comments
Labels

Comments

@sheinbergon
Copy link

sheinbergon commented Nov 8, 2016

Hi

I'm aware of #7

However , I also found this

https://github.com/circlespainter/quasar-redis-example

@circlespainter / @pron amazing work.

What is the plan to merge the 'redis' branch to the master and release 'comsat-redis' as a stable feature ?

Can I help with something ?

@sheinbergon
Copy link
Author

@pron any comment ?

@circlespainter
Copy link
Member

comsat-redis implements Jedis only partially at this stage and, being a very young integration and notwithstanding the port of the test suite, there might well be serious bugs (e.g. performance or stability) when actually using it, so I'm not for releasing it immediately in an official stable.

It is also true that a wider user base would help with the sharp edges. @pron What do you think?

As for help sure, you could PR Jedis API coverage and more tests.

@pron
Copy link
Contributor

pron commented Dec 13, 2016

Perhaps @sheinbergon can give it a try using the redis branch, and we'll decide based on his experience.

@sheinbergon
Copy link
Author

Do you have any holes you'd like to cover in specific ?
Concurrency tests ? I'm willing to help , just provide the what :-)

@circlespainter
Copy link
Member

Here are a few ideas:

  • Using it in a real-world scenario as @pron suggested and providing improvements / fixes as PRs (best option IMO)
  • Concurrency / load tests / benchmarks with analysis and improvement PRs
  • More Jedis API coverege (and associated tests port), you can find a comprehensive list of unimplemented features in https://github.com/circlespainter/quasar-redis-example

@sheinbergon
Copy link
Author

@circlespainter @pron

OK . I'll run some manual tests for now the first chance I have and report back on the following subjects :

  • Functional tests
  • Load tests
  • Coverage tests ( based on importance )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants