Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple globs (negation specifically) #1

Open
yocontra opened this issue Dec 4, 2013 · 8 comments
Open

Multiple globs (negation specifically) #1

yocontra opened this issue Dec 4, 2013 · 8 comments

Comments

@yocontra
Copy link

yocontra commented Dec 4, 2013

No description provided.

@dominictarr
Copy link
Member

can you give an example of what the syntax would look like?

I'd be happy to take a pull request for this.
At least making a pull-request with tests will make this much more likely to happen.

@yocontra
Copy link
Author

yocontra commented Dec 4, 2013

glob(['./**/*.js', '!./node_modules/**/*.js']).pipe(log()) // glob all js files except vendor

Right now I have my own glob-stream module I'm going to implement this filter into but I will try to make some time to PR the feature into this lib as well so I can eventually switch to it.

@dominictarr
Copy link
Member

okay, looking forward to your pull request.

@ahdinosaur
Copy link
Member

i want this feature for the same use case, but i still need to wrap my head around what the code is doing... 😃

@joakim
Copy link

joakim commented Jan 18, 2017

Would it be possible to rewrite this to use micromatch, or is that simply not possible due to what the code does (which I also have a hard time wrapping my head around 😄).

@jamen
Copy link

jamen commented Jan 18, 2017

Just to chime in, I would like to use this for pull-vinyl, I suspect @joakim had same idea. :p

@joakim
Copy link

joakim commented Jan 18, 2017

You read my mind :) I'm working on a local fork of your (otherwise great) module right now actually, using @contra's glob-stream + stream-to-pull-stream instead of pull-glob. It works, but it feels dirty to convert between node stream and pull stream, I'd prefer a 100% pull stream solution.

@dominictarr
Copy link
Member

@joakim it would be very easy to have pull-glob support multiple globs with pull-cat! cat([glob(glob1), glob(glob2)]) etc. Maybe if glob is passed an array then it could just call to cat?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants