Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give nice error messages on qc_metadata fail #70

Open
pjotrp opened this issue May 28, 2020 · 3 comments
Open

Give nice error messages on qc_metadata fail #70

pjotrp opened this issue May 28, 2020 · 3 comments
Assignees
Milestone

Comments

@pjotrp
Copy link
Collaborator

pjotrp commented May 28, 2020

No description provided.

@pjotrp pjotrp self-assigned this May 28, 2020
@pjotrp pjotrp added this to the v1.1 milestone May 28, 2020
@pjotrp
Copy link
Collaborator Author

pjotrp commented May 29, 2020

On wikidata location fail it looks like



Your upload has failed.

            Uploader returned value 1 and said:DEBUG:__main__:Entering sequence uploader
INFO:googleapiclient.discovery:URL being requested: GET https://lugli.arvadosapi.com/discovery/v1/apis/arvados/v1/rest
DEBUG:__main__:Checking metadata
DEBUG:bh20sequploader.qc_metadata:  Testing  against shape https://raw.githubusercontent.com/arvados/bh20-seq-resource/master/bh20sequploader/bh20seq-shex.rdf#submissionShape
    Testing _:b1 against shape https://raw.githubusercontent.com/arvados/bh20-seq-resource/master/bh20sequploader/bh20seq-shex.rdf#sampleShape
    _:b1 context:
       MainSchema:sample _:b1 .
         _:b1 evs:C25164 "2020-05-13" .
         _:b1 obo:GAZ_00000448  .
         _:b1 sio:SIO_000115 "Myunique id" .

      Node:  not in value set:
	 {"values": [{"stem": "http://www.wikidata.org/entity/", "typ...
WARNING:__main__:Failed metadata qc

Not exactly helpful :)

@pjotrp pjotrp modified the milestones: v1.1, Go live 1.0 May 29, 2020
@LLTommy
Copy link
Collaborator

LLTommy commented Jun 8, 2020

This clearly tells us that you did something wrong in the sample part of the submission, I assume you did not enter a location at all, an empty string will not pass. :D

On a serious note, yes it would be good to have nicer messages but this is hard to accomplish. This comes at the moment from the ShEX library directly. For the UI, I propose some additional restrictions (e.g. java script check if what should be an IRI starts "http" or that it is not empty) - so we could catch some of those before submission.

@pjotrp
Copy link
Collaborator Author

pjotrp commented Jun 12, 2020

The best way to accomplish this is probably by parsing these messages and reformatting them ;). I'll move it to later.

@pjotrp pjotrp modified the milestones: Go live 1.0, Later Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants