Release v4.24.4 (#160)

* add minimum presence timeout (#159)

* Bump versions for 4.24.4 release

Includes compiled stuff

 - David

Author: raipubnub

.pubnub.yml

@@ -1,5 +1,12 @@
 --- 
 changelog: 
+  - 
+    changes: 
+      - 
+        text: "Add minimum presence timeout"
+        type: improvement
+    date: 2019-07-26
+    version: v4.24.4
   - 
     changes: 
       - 
@@ -663,4 +670,4 @@ supported-platforms:
       - "Ubuntu 14.04 and above"
       - "Windows 7, 8, 10"
     version: "Pubnub Javascript for Node"
-version: "4.24.3"
+version: "4.24.4"

CHANGELOG.md

@@ -1,4 +1,16 @@
-## [v4.24.3](https://github.com/pubnub/javascript/tree/v4.24.3)
+## [v4.24.4](https://github.com/pubnub/javascript/tree/v4.24.4)
+  July-26-2019
+
+
+  [Full Changelog](https://github.com/pubnub/javascript/compare/v4.24.0...v4.24.4)
+
+
+
+- ⭐ Add minimum presence timeout
+
+
+
+## [v4.24.3](https://github.com/pubnub/javascript/tree/v4.24.3)
   June-19-2019
 
 

README.md

@@ -22,5 +22,5 @@ please use the [master_3x](https://github.com/pubnub/javascript/tree/master_3x)
 
 
 
-* https://cdn.pubnub.com/sdk/javascript/pubnub.4.24.3.min.js
-* https://cdn.pubnub.com/sdk/javascript/pubnub.4.24.3.js
+* https://cdn.pubnub.com/sdk/javascript/pubnub.4.24.4.min.js
+* https://cdn.pubnub.com/sdk/javascript/pubnub.4.24.4.js

dist/titanium/pubnub.js

@@ -1,4 +1,4 @@
-/*! 4.24.3 / Consumer  */
+/*! 4.24.4 / Consumer  */
 (function webpackUniversalModuleDefinition(root, factory) {
 	if(typeof exports === 'object' && typeof module === 'object')
 		module.exports = factory();
@@ -429,6 +429,9 @@ return /******/ (function(modules) { // webpackBootstrap
 
 	function _classCallCheck(instance, Constructor) { if (!(instance instanceof Constructor)) { throw new TypeError("Cannot call a class as a function"); } }
 
+	var PRESENCE_TIMEOUT_MINIMUM = 20;
+	var PRESENCE_TIMEOUT_DEFAULT = 300;
+
 	var _class = function () {
 	  function _class(_ref) {
 	    var setup = _ref.setup,
@@ -485,7 +488,7 @@ return /******/ (function(modules) { // webpackBootstrap
 
 	    this.setSendBeaconConfig(setup.useSendBeacon || true);
 
-	    this.setPresenceTimeout(setup.presenceTimeout || 300);
+	    this.setPresenceTimeout(setup.presenceTimeout || PRESENCE_TIMEOUT_DEFAULT);
 
 	    if (setup.heartbeatInterval != null) {
 	      this.setHeartbeatInterval(setup.heartbeatInterval);
@@ -542,8 +545,16 @@ return /******/ (function(modules) { // webpackBootstrap
 	  }, {
 	    key: 'setPresenceTimeout',
 	    value: function setPresenceTimeout(val) {
-	      this._presenceTimeout = val;
+	      if (val >= PRESENCE_TIMEOUT_MINIMUM) {
+	        this._presenceTimeout = val;
+	      } else {
+	        this._presenceTimeout = PRESENCE_TIMEOUT_MINIMUM;
+
+	        console.log('WARNING: Presence timeout is less than the minimum. Using minimum value: ', this._presenceTimeout);
+	      }
+
 	      this.setHeartbeatInterval(this._presenceTimeout / 2 - 1);
+
 	      return this;
 	    }
 	  }, {
@@ -598,7 +609,7 @@ return /******/ (function(modules) { // webpackBootstrap
 	  }, {
 	    key: 'getVersion',
 	    value: function getVersion() {
-	      return '4.24.3';
+	      return '4.24.4';
 	    }
 	  }, {
 	    key: '_decideUUID',

dist/titanium/pubnub.min.js

@@ -1,4 +1,4 @@
-/*! 4.24.3 / Consumer  */
+/*! 4.24.4 / Consumer  */
 (function webpackUniversalModuleDefinition(root, factory) {
 	if(typeof exports === 'object' && typeof module === 'object')
 		module.exports = factory();
@@ -451,6 +451,9 @@ return /******/ (function(modules) { // webpackBootstrap
 
 	function _classCallCheck(instance, Constructor) { if (!(instance instanceof Constructor)) { throw new TypeError("Cannot call a class as a function"); } }
 
+	var PRESENCE_TIMEOUT_MINIMUM = 20;
+	var PRESENCE_TIMEOUT_DEFAULT = 300;
+
 	var _class = function () {
 	  function _class(_ref) {
 	    var setup = _ref.setup,
@@ -507,7 +510,7 @@ return /******/ (function(modules) { // webpackBootstrap
 
 	    this.setSendBeaconConfig(setup.useSendBeacon || true);
 
-	    this.setPresenceTimeout(setup.presenceTimeout || 300);
+	    this.setPresenceTimeout(setup.presenceTimeout || PRESENCE_TIMEOUT_DEFAULT);
 
 	    if (setup.heartbeatInterval != null) {
 	      this.setHeartbeatInterval(setup.heartbeatInterval);
@@ -564,8 +567,16 @@ return /******/ (function(modules) { // webpackBootstrap
 	  }, {
 	    key: 'setPresenceTimeout',
 	    value: function setPresenceTimeout(val) {
-	      this._presenceTimeout = val;
+	      if (val >= PRESENCE_TIMEOUT_MINIMUM) {
+	        this._presenceTimeout = val;
+	      } else {
+	        this._presenceTimeout = PRESENCE_TIMEOUT_MINIMUM;
+
+	        console.log('WARNING: Presence timeout is less than the minimum. Using minimum value: ', this._presenceTimeout);
+	      }
+
 	      this.setHeartbeatInterval(this._presenceTimeout / 2 - 1);
+
 	      return this;
 	    }
 	  }, {
@@ -620,7 +631,7 @@ return /******/ (function(modules) { // webpackBootstrap
 	  }, {
 	    key: 'getVersion',
 	    value: function getVersion() {
-	      return '4.24.3';
+	      return '4.24.4';
 	    }
 	  }, {
 	    key: '_decideUUID',

dist/web/pubnub.js

@@ -1,6 +1,6 @@
 {
   "name": "pubnub",
-  "version": "4.24.3",
+  "version": "4.24.4",
   "author": "PubNub <[email protected]>",
   "description": "Publish & Subscribe Real-time Messaging with PubNub",
   "bin": {},

dist/web/pubnub.min.js

@@ -9,6 +9,9 @@ import {
   ProxyStruct,
 } from '../flow_interfaces';
 
+const PRESENCE_TIMEOUT_MINIMUM: number = 20;
+const PRESENCE_TIMEOUT_DEFAULT: number = 300;
+
 type ConfigConstructArgs = {
   setup: InternalSetupStruct,
   db: DatabaseInterface,
@@ -186,7 +189,7 @@ export default class {
     // set config on beacon (https://developer.mozilla.org/en-US/docs/Web/API/Navigator/sendBeacon) usage
     this.setSendBeaconConfig(setup.useSendBeacon || true);
     // how long the SDK will report the client to be alive before issuing a timeout
-    this.setPresenceTimeout(setup.presenceTimeout || 300);
+    this.setPresenceTimeout(setup.presenceTimeout || PRESENCE_TIMEOUT_DEFAULT);
 
     if (setup.heartbeatInterval != null) {
       this.setHeartbeatInterval(setup.heartbeatInterval);
@@ -234,8 +237,20 @@ export default class {
   }
 
   setPresenceTimeout(val: number): this {
-    this._presenceTimeout = val;
+    if (val >= PRESENCE_TIMEOUT_MINIMUM) {
+      this._presenceTimeout = val;
+    } else {
+      this._presenceTimeout = PRESENCE_TIMEOUT_MINIMUM;
+
+      // eslint-disable-next-line no-console
+      console.log(
+        'WARNING: Presence timeout is less than the minimum. Using minimum value: ',
+        this._presenceTimeout
+      );
+    }
+
     this.setHeartbeatInterval(this._presenceTimeout / 2 - 1);
+
     return this;
   }
 
@@ -281,7 +296,7 @@ export default class {
   }
 
   getVersion(): string {
-    return '4.24.3';
+    return '4.24.4';
   }
 
   _decideUUID(providedUUID: string): string {