-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transfer js code in index.html into separate .js file #1181
Comments
Hi @TildaDares @jywarren do you want to assign this issue? Not sure if it's qualifies as FTO or not. If it does not qualifies as FTO, I'd like to claim this issue if okay by you. |
Hello, I wonder if maybe doing this for 1 file first would make a good
example to follow, and then we could create FTOs for others based on that
example? So perhaps if one of you would like to try the first one?
…On Tue, Oct 18, 2022 at 12:18 PM Segun ***@***.***> wrote:
Hi @TildaDares <https://github.com/TildaDares> @jywarren
<https://github.com/jywarren> do you want to assign this issue? Not sure
if it's qualifies as FTO or not.
If it does not qualifies as FTO, I'd like to claim this issue if okay by
you.
—
Reply to this email directly, view it on GitHub
<#1181 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAF6J76PVLFGF5FRDHLDNTWD3EULANCNFSM6AAAAAARIHU37U>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@jywarren, okay I'll try it. Thank you. |
@jywarren That sounds great |
@7malikk, okay... but not sure how we can achieve that. You can throw more light on this though. I thought @jywarren's idea is the way to go. One example, and then other first-timers can follow the example, something like that. The example from @AndroGenius-codes may just be all we need in the end. |
@segun-codes So what I'm trying to say is @AndroGenius-codes should make the correction (i.e moving the js to an external js file) Does this clarify things? |
@7malikk, not to complicate things, let's just go by @jywarren's suggestion re-affirmed by @TildaDares. So I will simply fix this issue. The first-timers can re-apply from my input if @jywarren find it okay of course. |
@segun-codes check your dm for the meet link, I'll clarify what I'm saying there. It's in accordance with @jywarren's suggestion but with a better application. |
@Ibom99 Hey there, @segun-codes already created a PR at #1186 regarding this. It will provide issues for others to resolve. |
index.html file currently contains Javascript code, this makes for a less readable and maintainable code especially as the codebase is set to become larger with more contributions from the community members. For this reason, it is important to transfer and maintain javascript code in a separate .js file different from the ./examples/index.html file as much as possible.
The text was updated successfully, but these errors were encountered: