Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer js code in index.html into separate .js file #1181

Closed
segun-codes opened this issue Oct 18, 2022 · 10 comments · Fixed by #1186
Closed

Transfer js code in index.html into separate .js file #1181

segun-codes opened this issue Oct 18, 2022 · 10 comments · Fixed by #1186

Comments

@segun-codes
Copy link
Collaborator

segun-codes commented Oct 18, 2022

index.html file currently contains Javascript code, this makes for a less readable and maintainable code especially as the codebase is set to become larger with more contributions from the community members. For this reason, it is important to transfer and maintain javascript code in a separate .js file different from the ./examples/index.html file as much as possible.

@segun-codes
Copy link
Collaborator Author

Hi @TildaDares @jywarren do you want to assign this issue? Not sure if it's qualifies as FTO or not.

If it does not qualifies as FTO, I'd like to claim this issue if okay by you.

@jywarren
Copy link
Member

jywarren commented Oct 18, 2022 via email

@segun-codes
Copy link
Collaborator Author

@jywarren, okay I'll try it. Thank you.

@7malikk
Copy link
Collaborator

7malikk commented Oct 18, 2022

@jywarren That sounds great
@segun-codes We could leave it to @AndroGenius-codes as he just requested to work on the archive page
You and i can work on converting the rest to FTOs, what do you say?

@segun-codes
Copy link
Collaborator Author

segun-codes commented Oct 18, 2022

@jywarren That sounds great @segun-codes We could leave it to @AndroGenius-codes as he just requested to work on the archive page You and i can work on converting the rest to FTOs, what do you say?

@7malikk, okay... but not sure how we can achieve that. You can throw more light on this though. I thought @jywarren's idea is the way to go. One example, and then other first-timers can follow the example, something like that. The example from @AndroGenius-codes may just be all we need in the end.

@7malikk
Copy link
Collaborator

7malikk commented Oct 18, 2022

@segun-codes So what I'm trying to say is @AndroGenius-codes should make the correction (i.e moving the js to an external js file)
Then you and I will create FTOs for the other issues. using @AndroGenius-codes implementation as an example.

Does this clarify things?

@segun-codes
Copy link
Collaborator Author

@segun-codes So what I'm trying to say is @AndroGenius-codes should make the correction (i.e moving the js to an external js file) Then you and I will create FTOs for the other issues. using @AndroGenius-codes implementation as an example.

Does this clarify things?

@7malikk, not to complicate things, let's just go by @jywarren's suggestion re-affirmed by @TildaDares. So I will simply fix this issue. The first-timers can re-apply from my input if @jywarren find it okay of course.

@7malikk
Copy link
Collaborator

7malikk commented Oct 18, 2022

@segun-codes So what I'm trying to say is @AndroGenius-codes should make the correction (i.e moving the js to an external js file) Then you and I will create FTOs for the other issues. using @AndroGenius-codes implementation as an example.

Does this clarify things?

@7malikk, not to complicate things, let's just go by @jywarren's suggestion re-affirmed by @TildaDares. So I will simply fix this issue. The first-timers can re-apply from my input if @jywarren find it okay of course.

@segun-codes check your dm for the meet link, I'll clarify what I'm saying there. It's in accordance with @jywarren's suggestion but with a better application.

@Ibom99
Copy link
Contributor

Ibom99 commented Oct 19, 2022

@jywarren can i try out #1184 as an example?

@7malikk
Copy link
Collaborator

7malikk commented Oct 19, 2022

@Ibom99 Hey there, @segun-codes already created a PR at #1186 regarding this.
And is awaiting a review. What you should do is take a look at the above-mentioned PR and create an FTO from the changes made by @segun-codes.

It will provide issues for others to resolve.
Just a thought, open to revision @jywarren @TildaDares @cesswairimu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants