diff --git a/CMakeLists.txt b/CMakeLists.txt index 034529b..69987d6 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -72,9 +72,9 @@ target_include_directories(${PROJECT_NAME} ${EIGEN3_INCLUDE_DIRS} ) if (WITH_PCL) - target_include_directories(${PROJECT_NAME} PUBLIC ${PCL_INCLUDE_DIRS}) + target_include_directories(${PROJECT_NAME} PRIVATE ${PCL_INCLUDE_DIRS}) target_compile_definitions(${PROJECT_NAME} PRIVATE ${PCL_DEFINITIONS} WITH_PCL) - target_link_directories(${PROJECT_NAME} PUBLIC ${PCL_LIBRARY_DIRS}) + target_link_directories(${PROJECT_NAME} PRIVATE ${PCL_LIBRARY_DIRS}) endif() # make eigen, pcl an threads transitive dependencies of dependent projects diff --git a/cmake/SickLMS5xxConfig.cmake.in b/cmake/SickLMS5xxConfig.cmake.in index a70ef51..c312bee 100644 --- a/cmake/SickLMS5xxConfig.cmake.in +++ b/cmake/SickLMS5xxConfig.cmake.in @@ -20,10 +20,3 @@ if(NOT TARGET SickLMS5xx::SickLMS5xx) include("${CMAKE_CURRENT_LIST_DIR}/SickLMS5xxTargets.cmake") endif() -# Have to come last as they modify some variable used above. -include(CMakeFindDependencyMacro) -find_dependency(Eigen3 3.3.4 REQUIRED) -find_dependency(PCL 1.11 REQUIRED COMPONENTS common io) -# link the deps so that client projects get them also -target_link_libraries(SickLMS5xx::SickLMS5xx INTERFACE Eigen3::Eigen pcl_common pcl_io) -target_include_directories(SickLMS5xx::SickLMS5xx INTERFACE $)