Fix LinkedIn API error Mutiple authentication

The error returned was 401 "Mutiple authentication schemes detected" and
it was caused because in the API request we were adding the parameter
&oauth2_access_token= as suggested by Caserta (2015).

http://pierrecaserta.com/go-oauth-facebook-github-twitter-google-plus/

Once that parameter was removed, the API returned the user data.

See: ashwinks/PHP-LinkedIn-SDK#25

Author: psimika

petfind/postgres/pets.go

@@ -70,6 +70,7 @@ func (db *store) GetPet(petID int64) (*petfind.Pet, error) {
 		&p.PlaceID,
 		&u.ID,
 		&u.GithubID,
+		&u.LinkedinID,
 		&u.Name,
 		&u.Login,
 		&u.Email,
@@ -131,6 +132,7 @@ func (db *store) GetFeaturedPets() ([]*petfind.Pet, error) {
 			&p.PlaceID,
 			&u.ID,
 			&u.GithubID,
+			&u.LinkedinID,
 			&u.Name,
 			&u.Login,
 			&u.Email,
@@ -168,6 +170,7 @@ func (db *store) GetAllPets() ([]petfind.Pet, error) {
 	  p.place_id,
 	  u.id,
 	  u.github_id,
+	  u.linkedin_id,
 	  u.name,
 	  u.login,
 	  u.email,
@@ -213,6 +216,7 @@ func (db *store) GetAllPets() ([]petfind.Pet, error) {
 			&p.PlaceID,
 			&u.ID,
 			&u.GithubID,
+			&u.LinkedinID,
 			&u.Name,
 			&u.Login,
 			&u.Email,
@@ -429,6 +433,7 @@ func (db *store) SearchPets(s petfind.Search) ([]*petfind.Pet, error) {
 			&p.PlaceID,
 			&u.ID,
 			&u.GithubID,
+			&u.LinkedinID,
 			&u.Name,
 			&u.Login,
 			&u.Email,

petfind/postgres/postgres.go

@@ -31,10 +31,10 @@ func (db *store) MakeSchema() error {
 	const users = `CREATE TABLE IF NOT EXISTS users (
 		id bigserial PRIMARY KEY,
 		github_id bigint DEFAULT 0,
-		linkedin_id varchar(100) NOT NULL,
+		linkedin_id varchar(100) NOT NULL DEFAULT '',
 		name varchar(70),
-		login varchar(70),
-		email varchar(70),
+		login varchar(70) NOT NULL DEFAULT '',
+		email varchar(70) NOT NULL DEFAULT '',
 		created timestamptz,
 		updated timestamptz
 	)`

petfind/postgres/users.go

@@ -159,7 +159,7 @@ func (db *store) PutLinkedinUser(llu *petfind.LinkedinUser) (u *petfind.User, er
 	UPDATE users SET
 	  name = $2,
 	  updated = now()
-	WHERE github_id = $1
+	WHERE linkedin_id = $1
 	RETURNING id, github_id, linkedin_id, login, name, email, created, updated
 	`
 		userInsertStmt = `
@@ -197,6 +197,7 @@ func (db *store) PutLinkedinUser(llu *petfind.LinkedinUser) (u *petfind.User, er
 	if err != nil {
 		return nil, err
 	}
+
 	return u, nil
 }
 

petfind/postgres/users_test.go

@@ -157,3 +157,63 @@ func TestPutGithubUser_emptyName(t *testing.T) {
 		t.Errorf("PutGithubUser with empty name -> user.Name=%q, expected %q", got, want)
 	}
 }
+func TestPutLinkedinbUser(t *testing.T) {
+	s := setup(t)
+	defer teardown(t, s)
+
+	// We Put the LinkedIn user for the first time. The user does not exist so we
+	// expect Put to create the user.
+	llu := &petfind.LinkedinUser{
+		ID:        "JANEDOE",
+		FirstName: "Jane",
+		LastName:  "Doe",
+	}
+	got, err := s.PutLinkedinUser(llu)
+	if err != nil {
+		t.Fatal("PutLinkedinUser for non existent user returned err:", err)
+	}
+
+	// Save created time to check it was the same when we Put for a second time
+	// below.
+	created := got.Created
+	// Ignore time values.
+	got.Created = time.Time{}
+	got.Updated = time.Time{}
+
+	want := &petfind.User{
+		ID:         1, // A newly created user should get ID 1 from Postgres.
+		LinkedinID: "JANEDOE",
+		Name:       "Jane Doe",
+	}
+	if !reflect.DeepEqual(got, want) {
+		t.Fatalf("PutLinkedinUser first run \nhave: %#v\nwant: %#v", got, want)
+	}
+
+	// Attempt to Put again the github User. The LinkedIn user should have been
+	// already been created from the previous run and we now expect the values
+	// to be updated.
+	llu = &petfind.LinkedinUser{
+		ID:        "JANEDOE",
+		FirstName: "Michaella", // changed
+		LastName:  "Neirou",    // changed
+	}
+	got, err = s.PutLinkedinUser(llu)
+	if err != nil {
+		t.Fatal("PutLinkedinUser for existing user returned err:", err)
+	}
+
+	// Ignore updated.
+	got.Updated = time.Time{}
+
+	want = &petfind.User{
+		ID:         1, // ID stays the same as we are doing an update.
+		LinkedinID: "JANEDOE",
+		Name:       "Michaella Neirou",
+		Created:    created,
+	}
+	// This time we expect the values to be updated but the created time should
+	// be the same as the first run.
+	if !reflect.DeepEqual(got, want) {
+		t.Fatalf("PutLinkedinUser second run \nhave: %#v\nwant: %#v", got, want)
+	}
+}

web/linkedin.go

@@ -124,8 +124,7 @@ func (s *server) handleLoginLinkedInCallback(w http.ResponseWriter, r *http.Requ
 }
 
 func getLinkedinUser(client *http.Client, accessToken string) (*petfind.LinkedinUser, error) {
-	fmt.Println("accessToken:", accessToken)
-	resp, err := client.Get("https://api.linkedin.com/v1/people/~?format=json&oauth2_access_token=" + accessToken)
+	resp, err := client.Get("https://api.linkedin.com/v1/people/~?format=json")
 
 	if err != nil {
 		return nil, err