fields_item: replace DomainBoundary with func

Author: JamesMcClung

src/include/fields_item.hxx

@@ -34,23 +34,11 @@ inline std::vector<std::string> addKindSuffix(
 // ======================================================================
 // ItemMomentBnd
 
-template <centering::Centering C>
-class DomainBoundary
+template <typename FE>
+void add_ghosts_boundary(const Grid_t& grid, FE& mres_gt, const Int3& ib, int p,
+                         int mb, int me, centering::Centering c)
 {
-public:
-  template <typename FE>
-  static void add_ghosts_boundary(const Grid_t& grid, FE& mres_gt,
-                                  const Int3& ib, int p, int mb, int me);
-};
-
-template <>
-class DomainBoundary<centering::CC>
-{
-public:
-  template <typename FE>
-  static void add_ghosts_boundary(const Grid_t& grid, FE& mres_gt,
-                                  const Int3& ib, int p, int mb, int me)
-  {
+  if (c == centering::CC) {
     // lo
     for (int d = 0; d < 3; d++) {
       // FIXME why reflect for open BCs?
@@ -67,17 +55,7 @@ public:
         add_ghosts_reflecting_hi_cc(grid.ldims, mres_gt, ib, p, d, mb, me);
       }
     }
-  }
-};
-
-template <>
-class DomainBoundary<centering::NC>
-{
-public:
-  template <typename FE>
-  static void add_ghosts_boundary(const Grid_t& grid, FE& mres_gt,
-                                  const Int3& ib, int p, int mb, int me)
-  {
+  } else if (c == centering::NC) {
     // lo
     for (int d = 0; d < 3; d++) {
       // FIXME why reflect for open BCs?
@@ -95,7 +73,7 @@ public:
       }
     }
   }
-};
+}
 
 // ======================================================================
 // ItemMomentBnd
@@ -111,8 +89,7 @@ public:
   void add_ghosts(const Grid_t& grid, storage_type& mres_gt, const Int3& ib)
   {
     for (int p = 0; p < mres_gt.shape(4); p++) {
-      DomainBoundary<C>::add_ghosts_boundary(grid, mres_gt, ib, p, 0,
-                                             mres_gt.shape(3));
+      add_ghosts_boundary(grid, mres_gt, ib, p, 0, mres_gt.shape(3), C);
     }
 
     bnd_.add_ghosts(grid, mres_gt, ib, 0, mres_gt.shape(3));
@@ -152,8 +129,8 @@ public:
   {
     Int3 ib = -mprts.grid().ibn;
     // FIXME, gt::gtensor and psc::gtensor are slightly different, and ideally
-    // zeros() shouldn't actually allocate, but probably it does, so this wastes
-    // memory and a copy
+    // zeros() shouldn't actually allocate, but probably it does, so this
+    // wastes memory and a copy
     storage_type mres =
       psc::mflds::zeros<value_type, space_type>(mprts.grid(), n_comps(), ib);
     moment_type{}(mres, ib, mprts);