Disable some warnings and improve Makefile

Author: Francisco Javier Trujillo Mata

Makefile

@@ -2,11 +2,18 @@ EE_LIB = libps2stuff.a
 
 EE_LDFLAGS  += -L. -L$(PS2SDK)/ports/lib
 EE_INCS     += -I./include -I$(PS2SDK)/ports/include
-EE_CFLAGS   += -D_DEBUG
-EE_CXXFLAGS += -D_DEBUG
+
+ifeq ($(DEBUG), 1)
+    EE_CFLAGS   += -D_DEBUG
+    EE_CXXFLAGS += -D_DEBUG
+endif
+
+# Disabling warnings
+WARNING_FLAGS = -Wno-strict-aliasing -Wno-conversion-null 
+
 # VU0 code is broken so disable for now
-EE_CFLAGS   += -DNO_VU0_VECTORS -DNO_ASM
-EE_CXXFLAGS += -DNO_VU0_VECTORS -DNO_ASM
+EE_CFLAGS   += $(WARNING_FLAGS) -DNO_VU0_VECTORS -DNO_ASM
+EE_CXXFLAGS += $(WARNING_FLAGS) -DNO_VU0_VECTORS -DNO_ASM
 
 EE_OBJS = \
 	src/core.o \

src/drawenv.cpp

@@ -174,7 +174,7 @@ void CDrawEnv::SendSettings(bool waitForEnd, bool flushCache)
 void CDrawEnv::SendSettings(CSCDmaPacket& packet)
 {
     bool opened_tag;
-    if (opened_tag = !packet.HasOpenTag())
+    if ((opened_tag = !packet.HasOpenTag()))
         packet.Cnt();
     packet.Add(&SettingsGifTag, uiNumGSRegs + 1);
     if (opened_tag)

src/packet.cpp

@@ -29,7 +29,7 @@ CDmaPacket::CDmaPacket(tU128* buffer, tU32 bufferQWSize, tDmaChannelId channel,
     , bDeallocateBuffer(false)
 {
     // PLIN
-    mErrorIf(memMapping == Core::MemMappings::Uncached || memMapping == Core::MemMappings::UncachedAccl && (tU32)buffer & (64 - 1),
+    mErrorIf(memMapping == Core::MemMappings::Uncached || ((memMapping == Core::MemMappings::UncachedAccl) && ((tU32)buffer & (64 - 1))),
         "Dma buffer should be aligned on a cache line (64-byte boundary) when using the uncached mem mappings!");
     mErrorIf((memMapping == Core::MemMappings::Uncached || memMapping == Core::MemMappings::UncachedAccl) && bufferQWSize & (4 - 1),
         "Dma buffer size should be a whole number of cache lines (64 bytes = 4 quads) when using the uncached mem mappings!");