Code review

jdnichollsc · jdnichollsc · commit 4be1d8ba1262 · 2021-06-27T01:58:28.000-05:00
diff --git a/src/InAppBrowser.android.ts b/src/InAppBrowser.android.ts
@@ -198,6 +198,8 @@ function setup() {
         }
       }
 
+      this.registerEvent();
+
       intent.setData(Uri.parse(url));
       if (inAppBrowserOptions[InAppBrowserModule.KEY_SHOW_PAGE_TITLE]) {
         builder.setShowTitle(!!inAppBrowserOptions[InAppBrowserModule.KEY_SHOW_PAGE_TITLE]);
@@ -206,8 +208,6 @@ function setup() {
         intent.putExtra(CustomTabsIntent.EXTRA_TITLE_VISIBILITY_STATE, CustomTabsIntent.NO_TITLE);
       }
 
-      this.registerEvent();
-
       this.currentActivity.startActivity(
         createStartIntent(this.currentActivity, intent),
         customTabsIntent.startAnimationBundle

Original file line number	Diff line number	Diff line change
`@@ -198,6 +198,8 @@ function setup() {`
`198`	`198`	`}`
`199`	`199`	`}`
`200`	`200`
	`201`	`+ this.registerEvent();`
	`202`	`+`
`201`	`203`	`intent.setData(Uri.parse(url));`
`202`	`204`	`if (inAppBrowserOptions[InAppBrowserModule.KEY_SHOW_PAGE_TITLE]) {`
`203`	`205`	`builder.setShowTitle(!!inAppBrowserOptions[InAppBrowserModule.KEY_SHOW_PAGE_TITLE]);`
`@@ -206,8 +208,6 @@ function setup() {`
`206`	`208`	`intent.putExtra(CustomTabsIntent.EXTRA_TITLE_VISIBILITY_STATE, CustomTabsIntent.NO_TITLE);`
`207`	`209`	`}`
`208`	`210`
`209`		`- this.registerEvent();`
`210`		`-`
`211`	`211`	`this.currentActivity.startActivity(`
`212`	`212`	`createStartIntent(this.currentActivity, intent),`
`213`	`213`	`customTabsIntent.startAnimationBundle`