From 360320e7669d2f5d34a6458054d606ba550a2296 Mon Sep 17 00:00:00 2001 From: Jeppy Date: Sat, 4 Jun 2022 11:24:41 +0200 Subject: [PATCH] ADD remark for long price fetching time (#134) --- README.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/README.md b/README.md index 0cc282c..57d0260 100644 --- a/README.md +++ b/README.md @@ -45,6 +45,12 @@ You can use the custom import format [here](https://github.com/provinzio/CoinTax Have a look at our [Wiki](https://github.com/provinzio/CoinTaxman/wiki) for more information on how to obtain the account statement for your exchange. +**Remark**: The first run might take a while to fetch all required prices into the local database. +The implementation is at the moment kinda bad and does one http request per required price. +E.g. 1.000 trades (1.000 "buys" and 1.000 "sells") require 2.000 price fetches (and perhaps more for the paid fees). +Each price fetch might take 3 seconds, which leads to 6.000 seconds = 1.6 hours. +After the first run, all prices are stored locally which reduces the runtime way below 5 minutes. + #### Makefile The Makefile offers multiple useful commands to quickly update the requirements, run the script, create a docker container, clean your code...