Skip to content

SCSS only component generation #90

@HeroicEric

Description

@HeroicEric

We're having an issue with the scss only kind components.

  • We have a ui-button component and a ui-button--default kind
  • We also have a ui-button--primary kind that is only defined by its scss file.
  • We are generating an app component for the ui-button--primary component but that generated component is a reexport of the ui-kind component when it should be the ui-button--default.

I think I tracked the problem down to this case statement https://github.com/prototypal-io/untitled-ui/blob/master/lib/resolver.js#L35-L50

In the case where:

let themeComponent = 'modules/ui-base-theme/components/ui-button--primary.js';
let themeDefaultComponent = 'modules/ui-base-theme/components/ui-button--default.js';
let themeKindComponent = 'modules/ui-base-theme/components/ui-kind.js';

I think this should be resolving to the themeDefaultComponent but is currently resolving themeKindComponent.

I'm not sure where context.js comes from here https://github.com/prototypal-io/untitled-ui/blob/master/lib/resolver.js#L42-L44 but it doesn't seem to include the themeDefaultComponent.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions