-
Notifications
You must be signed in to change notification settings - Fork 8
Closed
Description
We're having an issue with the scss only kind components.
- We have a
ui-buttoncomponent and aui-button--defaultkind - We also have a
ui-button--primarykind that is only defined by its scss file. - We are generating an app component for the
ui-button--primarycomponent but that generated component is a reexport of theui-kindcomponent when it should be theui-button--default.
I think I tracked the problem down to this case statement https://github.com/prototypal-io/untitled-ui/blob/master/lib/resolver.js#L35-L50
In the case where:
let themeComponent = 'modules/ui-base-theme/components/ui-button--primary.js';
let themeDefaultComponent = 'modules/ui-base-theme/components/ui-button--default.js';
let themeKindComponent = 'modules/ui-base-theme/components/ui-kind.js';I think this should be resolving to the themeDefaultComponent but is currently resolving themeKindComponent.
I'm not sure where context.js comes from here https://github.com/prototypal-io/untitled-ui/blob/master/lib/resolver.js#L42-L44 but it doesn't seem to include the themeDefaultComponent.
Metadata
Metadata
Assignees
Labels
No labels