diff --git a/cpp/src/parquet/encryption/external/dbpa_enum_utils.cc b/cpp/src/parquet/encryption/external/dbpa_enum_utils.cc index c5c824da5fda..4be95e6158f7 100644 --- a/cpp/src/parquet/encryption/external/dbpa_enum_utils.cc +++ b/cpp/src/parquet/encryption/external/dbpa_enum_utils.cc @@ -28,6 +28,8 @@ namespace parquet::encryption::external { // parquet::Type -> dbps::external::Type // Parquet types are coming from parquet/types.h // ------------------------------------------------------------ +// parquet::Type::UNDEFINED is excluded as it is not a +// Parquet type per-se, but rather a value used in exception cases. const std::unordered_map DBPAEnumUtils::parquet_to_external_type_map = { {parquet::Type::BOOLEAN, dbps::external::Type::BOOLEAN}, @@ -37,10 +39,8 @@ const std::unordered_map {parquet::Type::FLOAT, dbps::external::Type::FLOAT}, {parquet::Type::DOUBLE, dbps::external::Type::DOUBLE}, {parquet::Type::BYTE_ARRAY, dbps::external::Type::BYTE_ARRAY}, - {parquet::Type::FIXED_LEN_BYTE_ARRAY, dbps::external::Type::FIXED_LEN_BYTE_ARRAY}}; - // parquet::Type::UNDEFINED is excluded as it is not a - // Parquet type per-se, but rather a value used in exception cases. - + {parquet::Type::FIXED_LEN_BYTE_ARRAY, + dbps::external::Type::FIXED_LEN_BYTE_ARRAY}}; // ------------------------------------------------------------ // arrow::Compression -> dbps::external::CompressionCodec diff --git a/cpp/src/parquet/encryption/external/dbpa_enum_utils_test.cc b/cpp/src/parquet/encryption/external/dbpa_enum_utils_test.cc index 387e722c7829..6ebdfaf01c98 100644 --- a/cpp/src/parquet/encryption/external/dbpa_enum_utils_test.cc +++ b/cpp/src/parquet/encryption/external/dbpa_enum_utils_test.cc @@ -106,7 +106,8 @@ TEST_F(DBPAUtilsTest, AllValidTypeMappings) { EXPECT_NO_THROW(DBPAEnumUtils::ParquetTypeToDBPA(parquet_type)); } - EXPECT_THROW(DBPAEnumUtils::ParquetTypeToDBPA(parquet::Type::UNDEFINED), std::invalid_argument); + EXPECT_THROW(DBPAEnumUtils::ParquetTypeToDBPA(parquet::Type::UNDEFINED), + std::invalid_argument); } TEST_F(DBPAUtilsTest, AllValidCompressionMappings) { @@ -131,11 +132,11 @@ TEST_F(DBPAUtilsTest, MapSizeAssertions) { // This provides a direct way to verify map completeness // Parquet::Type::type assertions - EXPECT_EQ(parquet_type_enum_size_, 9) - << "Expected 9 parquet type mappings"; + EXPECT_EQ(parquet_type_enum_size_, 9) << "Expected 9 parquet type mappings"; // Excluding UNDEFINED - EXPECT_EQ(parquet_type_enum_size_ - 1, DBPAEnumUtils::parquet_to_external_type_map.size()) + EXPECT_EQ(parquet_type_enum_size_ - 1, + DBPAEnumUtils::parquet_to_external_type_map.size()) << "Expected 9 parquet type mappings (excluding UNDEFINED)"; // Excluding UNDEFINED