- Updating comments after code review.

Author: avalerio-tkd

src/processing/encryption_sequencer.cpp

@@ -147,9 +147,6 @@ bool DataBatchEncryptionSequencer::DecodeAndEncrypt(tcb::span<const uint8_t> pla
         // Encrypt the typed values buffer and level bytes, then join them into a single encrypted byte vector.
         auto encrypted_value_bytes = encryptor_->EncryptValueList(typed_buffer);
         auto encrypted_level_bytes = encryptor_->EncryptBlock(level_bytes);
-
-        // Encrypted payloads mostly have a low-compression ratio, so the gains in size from compression are minimal or negative.
-        // Therefore, the final joined encrypted bytes are returned as-is without compression.
         encrypted_result_ = JoinWithLengthPrefix(encrypted_level_bytes, encrypted_value_bytes);
 
         // Set the encryption type to per-value
@@ -232,9 +229,7 @@ bool DataBatchEncryptionSequencer::DecryptAndEncode(tcb::span<const uint8_t> cip
     if (encryption_mode == ENCRYPTION_MODE_PER_VALUE) {
 
         // Split the joined encrypted bytes, then decrypt the level and value bytes separately.
-        // The ciphertext payload is already the joined bytes without compression.
         auto [encrypted_level_bytes, encrypted_value_bytes] = SplitWithLengthPrefix(ciphertext);
-        
         auto level_bytes = encryptor_->DecryptBlock(encrypted_level_bytes);
         auto typed_buffer = encryptor_->DecryptValueList(encrypted_value_bytes);
 

src/processing/typed_buffer.h

@@ -155,14 +155,16 @@ ByteBuffer<Codec>::ByteBuffer(
     Codec codec)
     : elements_span_(elements_span),
       elements_span_size_(elements_span.size()),
+      // `num_elements_` is the expected number of elements in the buffer declared upfront.
+      // - if the actual payload count mismatches, exceptions are thrown.
       num_elements_(num_elements),
       codec_(std::move(codec)),
       // `element_iterator_current_ptr_` is initialized to the start of the span.
-      // - it points to the start of the span + the prefix size if there is one.
+      // - it is calculated to point to the start of the span + the prefix size if there is one.
       element_iterator_current_ptr_(
           elements_span.data() + std::min(prefix_size, elements_span_size_)),
       // `element_iterator_end_ptr_` is initialized to the end of the span.
-      // - it points to the start of the span + the size.
+      // - it is calculated to point to the start of the span + the size.
       element_iterator_end_ptr_(elements_span.data() + elements_span_size_),
       element_iterator_count_(0),
       prefix_size_(prefix_size),