Skip to content

Commit d607c9f

Browse files
Reduce labels per metric for indexing pressure metrics to cluster, node, and name to save on storage space.
Signed-off-by: emilandresentac <[email protected]>
1 parent 40b06f9 commit d607c9f

File tree

1 file changed

+13
-3
lines changed

1 file changed

+13
-3
lines changed

collector/nodes.go

+13-3
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ var (
9696
defaultRoleLabels = []string{"cluster", "host", "name"}
9797
defaultThreadPoolLabels = append(defaultNodeLabels, "type")
9898
defaultBreakerLabels = append(defaultNodeLabels, "breaker")
99-
defaultIndexingPressureLabels = append(defaultNodeLabels, "indexing_pressure")
99+
defaultIndexingPressureLabels = []string{"cluster", "host", "name", "indexing_pressure"}
100100
defaultFilesystemDataLabels = append(defaultNodeLabels, "mount", "path")
101101
defaultFilesystemIODeviceLabels = append(defaultNodeLabels, "device")
102102
defaultCacheLabels = append(defaultNodeLabels, "cache")
@@ -1628,7 +1628,12 @@ func NewNodes(logger log.Logger, client *http.Client, url *url.URL, all bool, no
16281628
return float64(indexingPressureMem.Current.AllInBytes)
16291629
},
16301630
Labels: func(cluster string, node NodeStatsNodeResponse, indexingPressure string) []string {
1631-
return append(defaultNodeLabelValues(cluster, node), indexingPressure)
1631+
return []string{
1632+
cluster,
1633+
node.Host,
1634+
node.Name,
1635+
indexingPressure,
1636+
}
16321637
},
16331638
},
16341639
{
@@ -1642,7 +1647,12 @@ func NewNodes(logger log.Logger, client *http.Client, url *url.URL, all bool, no
16421647
return float64(indexingPressureStats.LimitInBytes)
16431648
},
16441649
Labels: func(cluster string, node NodeStatsNodeResponse, indexingPressure string) []string {
1645-
return append(defaultNodeLabelValues(cluster, node), indexingPressure)
1650+
return []string{
1651+
cluster,
1652+
node.Host,
1653+
node.Name,
1654+
indexingPressure,
1655+
}
16461656
},
16471657
},
16481658
},

0 commit comments

Comments
 (0)