Skip to content
This repository was archived by the owner on Oct 10, 2020. It is now read-only.

Documenting some functions and methods that are difficult to understand. #1225

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Documenting some functions and methods that are difficult to understand. #1225

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eb3b061
Documenting some functions and methods that are difficult to understand.
scovl Apr 15, 2018
f22d27f
Some corrections
scovl Apr 16, 2018
fac36b3
Some corrections
scovl Apr 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions Atomic/atomic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,13 @@
from docker.errors import NotFound
from .discovery import RegistryInspect, RegistryInspectError


Copy link

@TomSweeneyRedHat TomSweeneyRedHat Apr 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd remove at least one if not two of these added blank lines.


def find_repo_tag(d, Id, image_name):

# The image_in_repotags function fetches the name of the image inside the "repotag" repository, and if it finds,
Copy link

@TomSweeneyRedHat TomSweeneyRedHat Apr 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggest "if finds," to "found,"

# returns the name of the image, or image list.

def image_in_repotags(image_name, repotags):
if image_name in repotags:
return image_name
Expand Down Expand Up @@ -118,6 +124,11 @@ def pull(self):
prevstatus = status
util.write_out("")

# If for some reason the NameError or AtributeError class appears in the path,
# the exception is thrown to ignore the "pass" problem.
# The NameError class handles only unqualified names while AtributeError,
Copy link
Collaborator

@giuseppe giuseppe Apr 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s|AtributeError|AttributeError|

# appears when an object does not support attribute references or assignments.

def set_args(self, args):
self.args = args
try:
Expand Down