Skip to content

Commit 9357373

Browse files
kryanbeaneopenshift-merge-bot[bot]
kryanbeane
authored and
openshift-merge-bot[bot]
committed
chore: update memory requirements for notebooks
1 parent da9bf49 commit 9357373

File tree

9 files changed

+54
-41
lines changed

9 files changed

+54
-41
lines changed

‎demo-notebooks/additional-demos/hf_interactive.ipynb‎

Lines changed: 15 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -86,18 +86,21 @@
8686
"# Create our cluster and submit\n",
8787
"# The SDK will try to find the name of your default local queue based on the annotation \"kueue.x-k8s.io/default-queue\": \"true\" unless you specify the local queue manually below\n",
8888
"cluster_name= \"hfgputest\"\n",
89-
"cluster = Cluster(ClusterConfiguration(name=cluster_name, \n",
90-
" head_extended_resource_requests={'nvidia.com/gpu':1}, # For GPU enabled workloads set the head_extended_resource_requests and worker_extended_resource_requests\n",
91-
" worker_extended_resource_requests={'nvidia.com/gpu':1},\n",
92-
" num_workers=1,\n",
93-
" worker_cpu_requests=8, \n",
94-
" worker_cpu_limits=8, \n",
95-
" worker_memory_requests=16, \n",
96-
" worker_memory_limits=16, \n",
97-
" # image=\"\", # Optional Field \n",
98-
" write_to_file=False, # When enabled Ray Cluster yaml files are written to /HOME/.codeflare/resources \n",
99-
" # local_queue=\"local-queue-name\" # Specify the local queue manually\n",
100-
" ))"
89+
"cluster = Cluster(ClusterConfiguration(\n",
90+
" name=cluster_name, \n",
91+
" head_memory_requests=6,\n",
92+
" head_memory_limits=8,\n",
93+
" head_extended_resource_requests={'nvidia.com/gpu':1}, # For GPU enabled workloads set the head_extended_resource_requests and worker_extended_resource_requests\n",
94+
" worker_extended_resource_requests={'nvidia.com/gpu':1},\n",
95+
" num_workers=1,\n",
96+
" worker_cpu_requests=8, \n",
97+
" worker_cpu_limits=8, \n",
98+
" worker_memory_requests=16, \n",
99+
" worker_memory_limits=16, \n",
100+
" # image=\"\", # Optional Field \n",
101+
" write_to_file=False, # When enabled Ray Cluster yaml files are written to /HOME/.codeflare/resources \n",
102+
" # local_queue=\"local-queue-name\" # Specify the local queue manually\n",
103+
"))"
101104
]
102105
},
103106
{

‎demo-notebooks/additional-demos/local_interactive.ipynb‎

Lines changed: 14 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -57,18 +57,20 @@
5757
"cluster_name = \"hfgputest-1\"\n",
5858
"\n",
5959
"cluster = Cluster(ClusterConfiguration(\n",
60-
" name=cluster_name,\n",
61-
" head_extended_resource_requests={'nvidia.com/gpu':0}, # For GPU enabled workloads set the head_extended_resource_requests and worker_extended_resource_requests\n",
62-
" worker_extended_resource_requests={'nvidia.com/gpu':0},\n",
63-
" num_workers=1,\n",
64-
" worker_cpu_requests=1,\n",
65-
" worker_cpu_limits=1,\n",
66-
" worker_memory_requests=4,\n",
67-
" worker_memory_limits=4,\n",
68-
" # image=\"\", # Optional Field \n",
69-
" write_to_file=False, # When enabled Ray Cluster yaml files are written to /HOME/.codeflare/resources \n",
70-
" # local_queue=\"local-queue-name\" # Specify the local queue manually\n",
71-
" ))"
60+
" name=cluster_name,\n",
61+
" head_memory_requests=6,\n",
62+
" head_memory_limits=8,\n",
63+
" head_extended_resource_requests={'nvidia.com/gpu':0}, # For GPU enabled workloads set the head_extended_resource_requests and worker_extended_resource_requests\n",
64+
" worker_extended_resource_requests={'nvidia.com/gpu':0},\n",
65+
" num_workers=1,\n",
66+
" worker_cpu_requests=1,\n",
67+
" worker_cpu_limits=1,\n",
68+
" worker_memory_requests=4,\n",
69+
" worker_memory_limits=6,\n",
70+
" # image=\"\", # Optional Field \n",
71+
" write_to_file=False, # When enabled Ray Cluster yaml files are written to /HOME/.codeflare/resources \n",
72+
" # local_queue=\"local-queue-name\" # Specify the local queue manually\n",
73+
"))"
7274
]
7375
},
7476
{

‎demo-notebooks/additional-demos/ray_job_client.ipynb‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,13 +59,15 @@
5959
"# The SDK will try to find the name of your default local queue based on the annotation \"kueue.x-k8s.io/default-queue\": \"true\" unless you specify the local queue manually below\n",
6060
"cluster = Cluster(ClusterConfiguration(\n",
6161
" name='jobtest',\n",
62+
" head_memory_requests=6,\n",
63+
" head_memory_limits=8,\n",
6264
" head_extended_resource_requests={'nvidia.com/gpu':0}, # For GPU enabled workloads set the head_extended_resource_requests and worker_extended_resource_requests\n",
6365
" worker_extended_resource_requests={'nvidia.com/gpu':0},\n",
6466
" num_workers=2,\n",
6567
" worker_cpu_requests=1,\n",
6668
" worker_cpu_limits=1,\n",
6769
" worker_memory_requests=4,\n",
68-
" worker_memory_limits=4,\n",
70+
" worker_memory_limits=6,\n",
6971
" # image=\"\", # Optional Field \n",
7072
" write_to_file=False # When enabled Ray Cluster yaml files are written to /HOME/.codeflare/resources \n",
7173
" # local_queue=\"local-queue-name\" # Specify the local queue manually\n",

‎demo-notebooks/guided-demos/0_basic_ray.ipynb‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -68,15 +68,15 @@
6868
" name='raytest', \n",
6969
" head_cpu_requests='500m',\n",
7070
" head_cpu_limits='500m',\n",
71-
" head_memory_requests=2,\n",
72-
" head_memory_limits=2,\n",
71+
" head_memory_requests=5,\n",
72+
" head_memory_limits=8,\n",
7373
" head_extended_resource_requests={'nvidia.com/gpu':0}, # For GPU enabled workloads set the head_extended_resource_requests and worker_extended_resource_requests\n",
7474
" worker_extended_resource_requests={'nvidia.com/gpu':0},\n",
7575
" num_workers=2,\n",
7676
" worker_cpu_requests='250m',\n",
7777
" worker_cpu_limits=1,\n",
7878
" worker_memory_requests=4,\n",
79-
" worker_memory_limits=4,\n",
79+
" worker_memory_limits=6,\n",
8080
" # image=\"\", # Optional Field \n",
8181
" write_to_file=False, # When enabled Ray Cluster yaml files are written to /HOME/.codeflare/resources \n",
8282
" # local_queue=\"local-queue-name\" # Specify the local queue manually\n",

‎demo-notebooks/guided-demos/1_cluster_job_client.ipynb‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -61,15 +61,15 @@
6161
" name='jobtest',\n",
6262
" head_cpu_requests=1,\n",
6363
" head_cpu_limits=1,\n",
64-
" head_memory_requests=4,\n",
65-
" head_memory_limits=4,\n",
64+
" head_memory_requests=6,\n",
65+
" head_memory_limits=8,\n",
6666
" head_extended_resource_requests={'nvidia.com/gpu':1}, # For GPU enabled workloads set the head_extended_resource_requests and worker_extended_resource_requests\n",
6767
" worker_extended_resource_requests={'nvidia.com/gpu':1},\n",
6868
" num_workers=2,\n",
6969
" worker_cpu_requests='250m',\n",
7070
" worker_cpu_limits=1,\n",
7171
" worker_memory_requests=4,\n",
72-
" worker_memory_limits=4,\n",
72+
" worker_memory_limits=6,\n",
7373
" # image=\"\", # Optional Field \n",
7474
" write_to_file=False, # When enabled Ray Cluster yaml files are written to /HOME/.codeflare/resources \n",
7575
" # local_queue=\"local-queue-name\" # Specify the local queue manually\n",

‎demo-notebooks/guided-demos/2_basic_interactive.ipynb‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@
6767
" head_cpu_requests=1,\n",
6868
" head_cpu_limits=1,\n",
6969
" head_memory_requests=6,\n",
70-
" head_memory_limits=6,\n",
70+
" head_memory_limits=8,\n",
7171
" head_extended_resource_requests={'nvidia.com/gpu':1}, # For GPU enabled workloads set the head_extended_resource_requests and worker_extended_resource_requests\n",
7272
" worker_extended_resource_requests={'nvidia.com/gpu':1},\n",
7373
" num_workers=2,\n",

‎demo-notebooks/guided-demos/3_widget_example.ipynb‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -68,15 +68,15 @@
6868
" name='widgettest',\n",
6969
" head_cpu_requests='500m',\n",
7070
" head_cpu_limits='500m',\n",
71-
" head_memory_requests=2,\n",
72-
" head_memory_limits=2,\n",
71+
" head_memory_requests=6,\n",
72+
" head_memory_limits=8,\n",
7373
" head_extended_resource_requests={'nvidia.com/gpu':0}, # For GPU enabled workloads set the head_extended_resource_requests and worker_extended_resource_requests\n",
7474
" worker_extended_resource_requests={'nvidia.com/gpu':0},\n",
7575
" num_workers=2,\n",
7676
" worker_cpu_requests='250m',\n",
7777
" worker_cpu_limits=1,\n",
78-
" worker_memory_requests=2,\n",
79-
" worker_memory_limits=2,\n",
78+
" worker_memory_requests=4,\n",
79+
" worker_memory_limits=6,\n",
8080
" # image=\"\", # Optional Field\n",
8181
" write_to_file=False, # When enabled Ray Cluster yaml files are written to /HOME/.codeflare/resources\n",
8282
" # local_queue=\"local-queue-name\" # Specify the local queue manually\n",

‎demo-notebooks/guided-demos/4_rayjob_existing_cluster.ipynb‎

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -75,13 +75,17 @@
7575
"source": [
7676
"cluster = Cluster(ClusterConfiguration(\n",
7777
" name='rayjob-cluster',\n",
78-
" head_extended_resource_requests={'nvidia.com/gpu':0},\n",
79-
" worker_extended_resource_requests={'nvidia.com/gpu':0},\n",
78+
" head_cpu_requests=1,\n",
79+
" head_cpu_limits=1,\n",
80+
" head_memory_requests=6,\n",
81+
" head_memory_limits=8,\n",
82+
" head_extended_resource_requests={'nvidia.com/gpu':1},\n",
83+
" worker_extended_resource_requests={'nvidia.com/gpu':1},\n",
8084
" num_workers=2,\n",
81-
" worker_cpu_requests=1,\n",
85+
" worker_cpu_requests='250m',\n",
8286
" worker_cpu_limits=1,\n",
8387
" worker_memory_requests=4,\n",
84-
" worker_memory_limits=4,\n",
88+
" worker_memory_limits=6,\n",
8589
"\n",
8690
"))\n",
8791
"\n",

‎demo-notebooks/guided-demos/5_submit_rayjob_cr.ipynb‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,11 +66,13 @@
6666
"outputs": [],
6767
"source": [
6868
"cluster_config = ManagedClusterConfig(\n",
69+
" head_memory_requests=6,\n",
70+
" head_memory_limits=8,\n",
6971
" num_workers=2,\n",
7072
" worker_cpu_requests=1,\n",
7173
" worker_cpu_limits=1,\n",
7274
" worker_memory_requests=4,\n",
73-
" worker_memory_limits=4,\n",
75+
" worker_memory_limits=6,\n",
7476
" head_accelerators={'nvidia.com/gpu': 0},\n",
7577
" worker_accelerators={'nvidia.com/gpu': 0},\n",
7678
")"

0 commit comments

Comments
 (0)