Skip to content

Commit f2e2259

Browse files
committed
fix: production builds cannot access store
regression from PR to integrate semver'd store #450
1 parent 2f6849d commit f2e2259

File tree

2 files changed

+13
-9
lines changed

2 files changed

+13
-9
lines changed

bin/codeflare

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,8 +101,11 @@ export KUI_ELECTRON_HOME="${KUI_ELECTRON_HOME-$NODE}"
101101

102102
if [ -z "$GUIDEBOOK_STORE" ]; then
103103
if [ -d "$HEADLESS"/../../node_modules/@guidebooks/store/dist/store ]; then
104-
# development builds
104+
# development
105105
export GUIDEBOOK_STORE="$HEADLESS"/../../node_modules/@guidebooks/store/dist/store
106+
elif [ -d "$HEADLESS"/../../store ]; then
107+
# production builds
108+
export GUIDEBOOK_STORE="$HEADLESS"/../../store
106109
elif [ -d "$HEADLESS"/store/dist/store ]; then
107110
# docker builds
108111
export GUIDEBOOK_STORE="$HEADLESS"/store

package.json

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -23,19 +23,20 @@
2323
"build:headless-maybe": "if [ ! -n \"$FAST\" ]; then npm run build:headless; fi",
2424
"build:headless": "CLIENT_HOME=$PWD webpack-cli --mode=${MODE-production} --config node_modules/@kui-shell/webpack/headless-webpack.config.js",
2525
"docker:debug": "ENTRYPOINT=bash ./bin/codeflare -d",
26-
"build:electron:mac:amd64": "KUI_HEADLESS_WEBPACK=true KUI_LAUNCHER=$PWD/bin/codeflare PLATFORM=mac ARCH=x64 kui-build-electron",
27-
"build:electron:mac:arm64": "KUI_HEADLESS_WEBPACK=true KUI_LAUNCHER=$PWD/bin/codeflare PLATFORM=mac ARCH=arm64 kui-build-electron",
28-
"build:electron:osx:amd64": "KUI_HEADLESS_WEBPACK=true KUI_LAUNCHER=$PWD/bin/codeflare npm run build:electron:mac:amd64",
29-
"build:electron:osx:arm64": "KUI_HEADLESS_WEBPACK=true KUI_LAUNCHER=$PWD/bin/codeflare npm run build:electron:mac:arm64",
26+
"store-for-prod": "rm -rf store && cp -a node_modules/@guidebooks/store/dist/store .",
27+
"build:electron:mac:amd64": "npm run store-for-prod && KUI_HEADLESS_WEBPACK=true KUI_LAUNCHER=$PWD/bin/codeflare PLATFORM=mac ARCH=x64 kui-build-electron",
28+
"build:electron:mac:arm64": "npm run store-for-prod && KUI_HEADLESS_WEBPACK=true KUI_LAUNCHER=$PWD/bin/codeflare PLATFORM=mac ARCH=arm64 kui-build-electron",
29+
"build:electron:osx:amd64": "npm run build:electron:mac:amd64",
30+
"build:electron:osx:arm64": "npm run build:electron:mac:arm64",
3031
"build:electron:macOS:X64": "npm run build:electron:mac:amd64",
3132
"build:electron:macOS:ARM64": "npm run build:electron:mac:arm64",
32-
"build:electron:linux:amd64": "KUI_HEADLESS_WEBPACK=true KUI_LAUNCHER=$PWD/bin/codeflare PLATFORM=linux ARCH=x64 kui-build-electron",
33-
"build:electron:linux:arm64": "KUI_HEADLESS_WEBPACK=true KUI_LAUNCHER=$PWD/bin/codeflare PLATFORM=linux ARCH=arm64 kui-build-electron",
33+
"build:electron:linux:amd64": "npm run store-for-prod && KUI_HEADLESS_WEBPACK=true KUI_LAUNCHER=$PWD/bin/codeflare PLATFORM=linux ARCH=x64 kui-build-electron",
34+
"build:electron:linux:arm64": "npm run store-for-prod && KUI_HEADLESS_WEBPACK=true KUI_LAUNCHER=$PWD/bin/codeflare PLATFORM=linux ARCH=arm64 kui-build-electron",
3435
"build:electron:Linux:X64": "npm run build:electron:linux:amd64",
3536
"build:electron:Linux:ARM64": "npm run build:electron:linux:armd64",
36-
"build:electron:win32:amd64": "cross-env KUI_HEADLESS_WEBPACK=true KUI_LAUNCHER=$PWD/bin/codeflare PLATFORM=win32 ARCH=x64 kui-build-electron",
37+
"build:electron:win32:amd64": "npm run store-for-prod && cross-env KUI_HEADLESS_WEBPACK=true KUI_LAUNCHER=$PWD/bin/codeflare PLATFORM=win32 ARCH=x64 kui-build-electron",
3738
"build:electron:Windows:X64": "npm run build:electron:win32:amd64",
38-
"build:electron:all": "KUI_HEADLESS_WEBPACK=true KUI_LAUNCHER=$PWD/bin/codeflare kui-build-electron",
39+
"build:electron:all": "npm run store-for-prod && KUI_HEADLESS_WEBPACK=true KUI_LAUNCHER=$PWD/bin/codeflare kui-build-electron",
3940
"build": "npm run compile && webpack --mode production",
4041
"postinstall": "npm run compile",
4142
"format": "prettier --write '**/*.{scss,css,html,js,json,md,ts,tsx}'",

0 commit comments

Comments
 (0)