Skip to content

Commit a3276de

Browse files
committed
Address Atlantic review feedback
1 parent f19a659 commit a3276de

2 files changed

Lines changed: 5 additions & 1 deletion

File tree

packages/cloud/atlantic/src/index.test.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -350,6 +350,9 @@ function listInstancesResponse() {
350350
Timestamp: 1,
351351
'list-instancesresponse': {
352352
instancesSet: {
353+
metadata: {
354+
total: '2',
355+
},
353356
'1item': {
354357
InstanceId: '145607',
355358
rate_per_hr: '0.0341',

packages/cloud/atlantic/src/index.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,7 @@ export default defineCloud<Config>({
8181
ctx.log('atlantic connect · verifying credentials...');
8282
await atlanticRequest(ctx, config, 'list-instances');
8383
ctx.log('atlantic connected');
84+
// Atlantic.Net's Cloud API credential-check path does not expose a stable account id.
8485
return { accountId: 'atlantic-account' };
8586
},
8687

@@ -443,7 +444,7 @@ function itemsFromSet<T>(set: unknown): T[] {
443444
if (value === undefined) continue;
444445
if (Array.isArray(value)) {
445446
values.push(...value as T[]);
446-
} else if (key === 'item' || key.endsWith('item') || isRecord(value)) {
447+
} else if (key === 'item' || key.endsWith('item')) {
447448
values.push(value as T);
448449
}
449450
}

0 commit comments

Comments
 (0)