Honor Linode volume price budgets

Author: caydyan

packages/cloud/linode/src/index.test.ts

@@ -151,6 +151,24 @@ describe('Linode cloud adapter', () => {
     expect(second.length).toBeLessThanOrEqual(32);
   });
 
+  it('does not create block storage when maxHourlyPrice is below the volume rate', async () => {
+    const fetchMock = vi.fn();
+    vi.stubGlobal('fetch', fetchMock);
+
+    await expect(adapter.provision({
+      secret: (key: string) => key === 'LINODE_API_TOKEN' ? 'token' : undefined,
+      log: vi.fn(),
+      dryRun: false,
+    }, {
+      kind: 'block-storage',
+      storage: 20,
+      region: 'us-east',
+      maxHourlyPrice: 0.001,
+    }, {})).rejects.toThrow('exceeds maxHourlyPrice');
+
+    expect(fetchMock).not.toHaveBeenCalled();
+  });
+
   it('requires a login mechanism before non-dry-run image provisioning', async () => {
     vi.stubGlobal('fetch', vi.fn().mockResolvedValue({
       ok: true,

packages/cloud/linode/src/index.ts

@@ -103,7 +103,7 @@ export default defineCloud<Config>({
     if (spec.kind === 'block-storage') {
       const monthly = (spec.storage ?? 10) * VOLUME_MONTHLY_PER_GB;
       return {
-        hourly: monthly / 730,
+        hourly: volumeHourlyRate(spec.storage ?? 10),
         monthly,
         currency: 'USD',
         provider: 'linode',
@@ -136,6 +136,10 @@ export default defineCloud<Config>({
     if (ctx.dryRun) return { ...stubInstance('dry-run', 'provisioning', spec.kind), region };
 
     if (spec.kind === 'block-storage') {
+      const hourly = volumeHourlyRate(spec.storage ?? 10);
+      if (spec.maxHourlyPrice !== undefined && hourly > spec.maxHourlyPrice) {
+        throw new Error(`linode: block-storage hourly price $${hourly} exceeds maxHourlyPrice $${spec.maxHourlyPrice}`);
+      }
       ctx.log(`linode provision - volume region=${region} size=${spec.storage ?? 10}GB`);
       const volume = await linodeRequest<LinodeVolume>(ctx, 'POST', '/volumes', {
         label,
@@ -304,13 +308,17 @@ function volumeToInstance(volume: LinodeVolume): Instance {
     kind: 'block-storage',
     status: statusMap[volume.status] ?? 'provisioning',
     createdAt: volume.created,
-    hourlyRate: (volume.size * VOLUME_MONTHLY_PER_GB) / 730,
+    hourlyRate: volumeHourlyRate(volume.size),
     currency: 'USD',
     region: volume.region,
     tags: volume.tags,
   };
 }
 
+function volumeHourlyRate(sizeGb: number): number {
+  return (sizeGb * VOLUME_MONTHLY_PER_GB) / 730;
+}
+
 function hasHardwareConstraints(spec: InstanceSpec): boolean {
   return !!(spec.cpu || spec.memory || spec.storage || spec.gpu?.count);
 }